move windows when disconnecting secondary monitors

ash/root_window_controller_unittest.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/monitor/monitor_controller.h"
+#include "ash/monitor/multi_monitor_manager.h"
+#include "ash/shell.h"
+#include "ash/shell_window_ids.h"
+#include "ash/test/ash_test_base.h"
+#include "ash/wm/window_util.h"
+#include "ui/aura/env.h"
+#include "ui/aura/root_window.h"
+#include "ui/aura/test/event_generator.h"
+#include "ui/aura/window.h"
+#include "ui/views/widget/widget.h"
+#include "ui/views/widget/widget_delegate.h"
+
+namespace ash {
+namespace {
+
+class ModalWindow : public views::WidgetDelegateView {
+ public:
+  ModalWindow() {}
+  virtual ~ModalWindow() {}
+
+  // Overridden from views::WidgetDelegate:
+  virtual views::View* GetContentsView() OVERRIDE {
+    return this;
+  }
+  virtual ui::ModalType GetModalType() const OVERRIDE {
+    return ui::MODAL_TYPE_SYSTEM;
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ModalWindow);
+};
+
+views::Widget* CreateTestWidget(const gfx::Rect& bounds) {
+  views::Widget* widget = views::Widget::CreateWindowWithBounds(NULL, bounds);
+  widget->Show();
+  return widget;
+}
+
+views::Widget* CreateModalWidget(const gfx::Rect& bounds) {
+  views::Widget* widget =
+      views::Widget::CreateWindowWithBounds(new ModalWindow(), bounds);
+  widget->Show();
+  return widget;
+}
+
+aura::Window* GetModalContainer(aura::RootWindow* root_window) {
+  return Shell::GetContainer(
+      root_window,
+      ash::internal::kShellWindowId_SystemModalContainer);
+}
+
+}  // namespace
+
+namespace test {
+class RootWindowControllerTest : public test::AshTestBase {
+ public:
+  RootWindowControllerTest() {}
+  virtual ~RootWindowControllerTest() {}
+
+  virtual void SetUp() OVERRIDE {
+    internal::MonitorController::SetExtendedDesktopEnabled(true);
+    internal::MonitorController::SetVirtualScreenCoordinatesEnabled(true);
+    AshTestBase::SetUp();
+  }
+
+  virtual void TearDown() OVERRIDE {
+    AshTestBase::TearDown();
+    internal::MonitorController::SetExtendedDesktopEnabled(false);
+    internal::MonitorController::SetVirtualScreenCoordinatesEnabled(false);
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(RootWindowControllerTest);
+};
+
+TEST_F(RootWindowControllerTest, MoveWindows_Basic) {
+  UpdateMonitor("0+0-600x600,600+0-500x500");
+  Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
+  // Emulate virtual screen coordinate system.
+  root_windows[0]->SetBounds(gfx::Rect(0, 0, 600, 600));
+  root_windows[1]->SetBounds(gfx::Rect(600, 0, 500, 500));
+
+  // TODO(oshima): Creating minimized window here and move causes
+  // maximized window to report 500x500 after move. It looks working
+  // when tested using ash (the window is maximzied on the primary
+  // display), so it could be just returning false value. Investigate
+  // why.

[oshima, 2012/06/25 21:34:09]

Scott, do you have any clue what's causing this? If not, I'll look into this in
separate CL.

[sky, 2012/06/25 22:05:14]

I don't know exactly what the bug is. The code should end up in
ScreenAsh::GetMaximizedWindowBounds which seems to be multi-mon aware, so I'm
not sure.

[oshima, 2012/06/25 22:42:28]

Never miond. I rewrite the test and it seems to be working, so I probably had
some bug in the old test code.

+
+  views::Widget* normal = CreateTestWidget(gfx::Rect(650, 10, 100, 100));
+  EXPECT_EQ(root_windows[1], normal->GetNativeView()->GetRootWindow());
+  EXPECT_EQ("100x100", normal->GetWindowScreenBounds().size().ToString());
+
+  views::Widget* maximized = CreateTestWidget(gfx::Rect(700, 10, 100, 100));
+  maximized->Maximize();
+  EXPECT_EQ("500x500", maximized->GetWindowScreenBounds().size().ToString());
+  EXPECT_EQ(root_windows[1], maximized->GetNativeView()->GetRootWindow());
+
+  views::Widget* fullscreen = CreateTestWidget(gfx::Rect(900, 10, 100, 100));
+  fullscreen->SetFullscreen(true);
+  EXPECT_EQ(root_windows[1], fullscreen->GetNativeView()->GetRootWindow());
+  EXPECT_EQ("500x500", fullscreen->GetWindowScreenBounds().size().ToString());
+
+  UpdateMonitor("0+0-600x600");
+
+  EXPECT_EQ(root_windows[0], normal->GetNativeView()->GetRootWindow());
+  EXPECT_EQ("100x100", normal->GetWindowScreenBounds().size().ToString());
+
+  // Maximized area on primary monitor has 2px (given as
+  // kAutoHideSize in shelf_layout_manager.cc) inset at the bottom.
+  EXPECT_EQ(root_windows[0], maximized->GetNativeView()->GetRootWindow());
+  EXPECT_EQ("600x598", maximized->GetWindowScreenBounds().size().ToString());
+
+  EXPECT_EQ(root_windows[0], fullscreen->GetNativeView()->GetRootWindow());
+  EXPECT_TRUE(fullscreen->IsFullscreen());
+  EXPECT_EQ("600x600", fullscreen->GetWindowScreenBounds().size().ToString());
+}
+
+TEST_F(RootWindowControllerTest, MoveWindows_Modal) {
+  UpdateMonitor("0+0-500x500,500+0-500x500");
+
+  Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
+  // Emulate virtual screen coordinate system.
+  root_windows[0]->SetBounds(gfx::Rect(0, 0, 500, 500));
+  root_windows[1]->SetBounds(gfx::Rect(500, 0, 500, 500));
+
+  views::Widget* normal = CreateTestWidget(gfx::Rect(300, 10, 100, 100));
+  EXPECT_EQ(root_windows[0], normal->GetNativeView()->GetRootWindow());
+  EXPECT_TRUE(wm::IsActiveWindow(normal->GetNativeView()));
+
+  views::Widget* modal = CreateModalWidget(gfx::Rect(650, 10, 100, 100));
+  EXPECT_EQ(root_windows[1], modal->GetNativeView()->GetRootWindow());
+  EXPECT_TRUE(GetModalContainer(root_windows[1])->Contains(
+      modal->GetNativeView()));
+  EXPECT_TRUE(wm::IsActiveWindow(modal->GetNativeView()));
+
+  aura::test::EventGenerator generator_1st(root_windows[0]);
+  generator_1st.ClickLeftButton();
+  EXPECT_TRUE(wm::IsActiveWindow(modal->GetNativeView()));
+
+  UpdateMonitor("0+0-500x500");
+  EXPECT_EQ(root_windows[0], modal->GetNativeView()->GetRootWindow());
+  EXPECT_TRUE(wm::IsActiveWindow(modal->GetNativeView()));
+  generator_1st.ClickLeftButton();
+  EXPECT_TRUE(wm::IsActiveWindow(modal->GetNativeView()));
+}
+
+}  // namespace test
+}  // namespace ash