Issue 10666: Omnibox metrics logging patch splitout, part 6: Log more omnibox data (client...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10666: Omnibox metrics logging patch splitout, part 6: Log more omnibox data (client... (Closed)

Created:
12 years, 1 month ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Omnibox metrics logging patch splitout, part 6: Log more omnibox data (client side). This is the last patch. It can't go in until Evan and I test it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7032

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -2 lines)			Patch
M	chrome/browser/autocomplete/autocomplete.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/metrics_log.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM

And thanks for splitting it up.