Extension Docs Server 2: Redirect code.google.com/chrome/extensions to

chrome/common/extensions/docs/server2/handler.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 from StringIO import StringIO
 import sys
 
 from appengine_wrappers import webapp
@@ skipping 126 matching lines @@
     self.out = StringIO()
     self.headers = {}
 
   def set_status(self, status):
     self.status = status
 
 class _MockRequest(object):
   def __init__(self, path):
     self.headers = {}
     self.path = path
+    self.url = 'http://localhost' + path
 
 class Handler(webapp.RequestHandler):
   def __init__(self, request, response, local_path=EXTENSIONS_PATH):
     self._local_path = local_path
     super(Handler, self).__init__(request, response)
 
   def _HandleGet(self, path):
     channel_name, real_path = BRANCH_UTILITY.SplitChannelNameFromPath(path)
     # TODO: Detect that these are directories and serve index.html out of them.
     if real_path.strip('/') == 'apps':
@@ skipping 63 matching lines @@
       # If |needs_render| was True, this page was already rendered, and we don't
       # need to render again.
       github_invalidation_cache = GITHUB_COMPILED_FILE_SYSTEM.Create(
           lambda _: needs_render.Set(True),
           compiled_fs.CRON_GITHUB_INVALIDATION)
       if needs_render.Get():
         self._Render([PUBLIC_TEMPLATE_PATH + '/apps/samples.html'], channel)
 
     self.response.out.write('Success')
 
+

[not at google - send to devlin, 2012/08/29 07:20:46]

nits: surrounding this method in 2 blank lines on each side seems unnecessary.

[Aaron Boodman, 2012/08/29 19:42:42]

Done.

+  def _RedirectFromCodeDotGoogleDotCom(self, path):
+    if (not self.request.url.startswith(('http://code.google.com',
+                                         'https://code.google.com'))):
+      return False
+
+    newUrl = 'http://developer.chrome.com/'
+
+    # switch to https if necessary
+    if (self.request.url.startswith('https')):
+      newUrl = newUrl.replace('http', 'https', 1)
+
+    path = path.split('/')
+    if len(path) > 0 and path[0] == 'chrome':
+      path.pop(0)
+    for channel in ['dev', 'beta', 'stable', 'trunk']:

[not at google - send to devlin, 2012/08/29 07:20:46]

I've been trying to keep knowledge of the branches inside BRANCH_UTILITY. Could
you add this as GetAllChannels() on BranchUtility?

Side note: GetAllBranchNumbers doesn't need to know about 'local'.

[Aaron Boodman, 2012/08/29 19:42:42]

Done.
Did not feel confident making this change, but added TODO.

+      if channel in path:
+        position = path.index(channel)
+        path.pop(position)
+        path.insert(0, channel)
+    newUrl += '/'.join(path)
+    self.redirect(newUrl)
+    return True
+
+
   def get(self):
     path = self.request.path
     if path.startswith('/cron'):
       self._HandleCron(path)
-    else:
-      # Redirect paths like "directory" to "directory/". This is so relative
-      # file paths will know to treat this as a directory.
-      if os.path.splitext(path)[1] == '' and path[-1] != '/':
-        self.redirect(path + '/')
-      path = path.replace('/chrome/', '')
-      path = path.strip('/')
+      return
+
+    # Redirect paths like "directory" to "directory/". This is so relative
+    # file paths will know to treat this as a directory.
+    if os.path.splitext(path)[1] == '' and path[-1] != '/':
+      self.redirect(path + '/')
+      return
+
+    path = path.strip('/')
+    if not self._RedirectFromCodeDotGoogleDotCom(path):
       self._HandleGet(path)