Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Issue 1092143003: Plugin Power Saver: Allow Enterprise ASK policy users to manually play. (Closed)

Created:
5 years, 8 months ago by tommycli
Modified:
5 years, 8 months ago
CC:
chromium-reviews, jam, Bernhard Bauer, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Allow Enterprise ASK policy users to manually play. - In M42, we removed ASK (Left click to play) for plugins and interpreted all ASK users as BLOCK. - For users on BLOCK via policy, the manually play option is grayed out, presumably because enterprise admins don't want users to be able to override their policies. - This has the unintended consequence of causing managed ASK users to be unable to play plugins. - That seems against admin intent, and this patch allows legacy ASK policy users to right click to play. - This is a minimal patch intended to be merged into M42 and M43. BUG=477625 Committed: https://crrev.com/d727a4c52ad22fac99074db4775ef8329bfb25eb Cr-Commit-Position: refs/heads/master@{#326050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/plugins/plugin_info_message_filter.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
tommycli
thestig: PTAL. Thanks! This intended to be merged into 43 and 42 though I am ...
5 years, 8 months ago (2015-04-20 22:10:49 UTC) #2
Lei Zhang
lgtm +bauerb FYI
5 years, 8 months ago (2015-04-21 01:43:26 UTC) #3
Bernhard Bauer
LGTM BTW, something for a potential follow-up commit that is not going to merged: I ...
5 years, 8 months ago (2015-04-21 07:39:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092143003/1
5 years, 8 months ago (2015-04-21 16:31:04 UTC) #7
tommycli
thestig/bauerb: Thank you for the prompt reviews. I'll make sure this gets merged into 42/43.
5 years, 8 months ago (2015-04-21 16:31:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 16:35:16 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 16:36:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d727a4c52ad22fac99074db4775ef8329bfb25eb
Cr-Commit-Position: refs/heads/master@{#326050}

Powered by Google App Engine
This is Rietveld 408576698