Add gaia_id to ProfileInfoCache.

Add gaia_id to ProfileInfoCache.
Renaming sync_state to username.

BUG=None

Committed: https://crrev.com/e2265960703ea8840d20966ce38442e9aaa8eb0a
Cr-Commit-Position: refs/heads/master@{#329244}

[Roger Tawa OOO till Jul 10th, 2015-04-29 02:35:11]

Patchset #1 (id:1) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-04-29 02:35:17]

Patchset #1 (id:20001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-04-30 16:38:51]

Patchset #1 (id:40001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-04-30 16:38:59]

Patchset #1 (id:60001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-04-30 16:39:07]

Patchset #1 (id:80001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-04-30 16:39:13]

Patchset #1 (id:100001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-04-30 16:39:25]

Patchset #1 (id:120001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-05-01 16:38:36]

Patchset #2 (id:160001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-05-01 16:38:43]

Patchset #2 (id:180001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-05-01 17:35:50]

Patchset #2 (id:200001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-05-01 17:44:20]

[email protected] changed reviewers:
+ [email protected]

[Roger Tawa OOO till Jul 10th, 2015-05-01 17:44:21]

Hi Monica,

I am adding the gaia-id field to the profile info cache.  Username and gaia-id
really go together.  It would be great to get rid of username and have code get
it from the account tracker service, that does not work since the profiles are
not necessarily open, so can't get to account tracker service.

The CL looks big but I changed a public API so had to update lots of places.

Thanks.

[noms (inactive), 2015-05-06 01:05:54]

This looks great! LGTM % nits :)

https://codereview.chromium.org/1117453002/diff/260001/chrome/browser/profile...
File chrome/browser/profiles/avatar_menu.h (right):

https://codereview.chromium.org/1117453002/diff/260001/chrome/browser/profile...
chrome/browser/profiles/avatar_menu.h:59: // A string representing the username
of the profile, if signed in.
nit: can you add an extra "; empty otherwise"?

https://codereview.chromium.org/1117453002/diff/260001/chrome/browser/profile...
File chrome/browser/profiles/profile_info_cache.cc (right):

https://codereview.chromium.org/1117453002/diff/260001/chrome/browser/profile...
chrome/browser/profiles/profile_info_cache.cc:550:
info.reset(GetInfoForProfileAtIndex(index)->DeepCopy());
Just a thought: is there a benefit from resetting |info| like this? Why not
initialize it directly with |GetInfoForProfile...| like before? Like, get and
store the old gaia_id/usernames, bail early if they're empty, and if not,
initialize info with the deep copy and set the appropriate strings. Maybe?

https://codereview.chromium.org/1117453002/diff/260001/chrome/browser/profile...
File chrome/browser/profiles/profile_manager.cc (right):

https://codereview.chromium.org/1117453002/diff/260001/chrome/browser/profile...
chrome/browser/profiles/profile_manager.cc:1261:
AccountTrackerService::AccountInfo info =
nit: s/info/account_info maybe? 30 lines later info.gaia looks a bit random

[Roger Tawa OOO till Jul 10th, 2015-05-11 16:09:56]

[email protected] changed reviewers:
+ [email protected], [email protected], [email protected],
[email protected]

[Roger Tawa OOO till Jul 10th, 2015-05-11 16:09:57]

Thanks Monica.

Hi Alexei, Evan, Ken, Peter, Scott, Xiyuan,

Can you please do owner review?

Alexei:
chrome/browser/ui/cocoa/*

Evan:
chrome/browser/ui/webui/ntp/*

Ken:
chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc

Peter:
chrome/browser/notifications/*

Scott:
chrome/browser/ui/views/profiles/*

Xiyuan:
chrome/browser/chromeos/*

Thanks.

https://codereview.chromium.org/1117453002/diff/260001/chrome/browser/profile...
File chrome/browser/profiles/avatar_menu.h (right):

https://codereview.chromium.org/1117453002/diff/260001/chrome/browser/profile...
chrome/browser/profiles/avatar_menu.h:59: // A string representing the username
of the profile, if signed in.
On 2015/05/06 01:05:54, noms (slow. ping if too slow) wrote:
> nit: can you add an extra "; empty otherwise"? 

Done.

https://codereview.chromium.org/1117453002/diff/260001/chrome/browser/profile...
File chrome/browser/profiles/profile_info_cache.cc (right):

https://codereview.chromium.org/1117453002/diff/260001/chrome/browser/profile...
chrome/browser/profiles/profile_info_cache.cc:550:
info.reset(GetInfoForProfileAtIndex(index)->DeepCopy());
On 2015/05/06 01:05:54, noms (slow. ping if too slow) wrote:
> Just a thought: is there a benefit from resetting |info| like this? Why not
> initialize it directly with |GetInfoForProfile...| like before? Like, get and
> store the old gaia_id/usernames, bail early if they're empty, and if not,
> initialize info with the deep copy and set the appropriate strings. Maybe?

Done.

https://codereview.chromium.org/1117453002/diff/260001/chrome/browser/profile...
File chrome/browser/profiles/profile_manager.cc (right):

https://codereview.chromium.org/1117453002/diff/260001/chrome/browser/profile...
chrome/browser/profiles/profile_manager.cc:1261:
AccountTrackerService::AccountInfo info =
On 2015/05/06 01:05:54, noms (slow. ping if too slow) wrote:
> nit: s/info/account_info maybe? 30 lines later info.gaia looks a bit random

Done.

[Roger Tawa OOO till Jul 10th, 2015-05-11 16:11:09]

[email protected] changed reviewers:
+ [email protected]

[Roger Tawa OOO till Jul 10th, 2015-05-11 16:11:10]

Hi Scott,

Please look at chrome/browser/ui/views/profiles/*

Thanks

[Ken Rockot(use gerrit already), 2015-05-11 16:13:14]

extensions lgtm

[xiyuan, 2015-05-11 16:38:17]

chromeos/ * LGTM

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/chromeo...
File chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc (right):

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/chromeo...
chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc:167:
cache->GetUserDataDir().AppendASCII("p2"), supervised_name, std::string(),
nit: std::string() -> "fake_gaia_id" for better readability?

[Peter Beverloo, 2015-05-11 16:44:17]

chrome/browser/notifications/ lgtm

[Alexei Svitkine (slow), 2015-05-11 17:04:11]

cocoa lgtm

[Evan Stade, 2015-05-11 17:11:53]

[email protected] changed reviewers:
+ [email protected]

[Evan Stade, 2015-05-11 17:11:54]

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/profile...
File chrome/browser/profiles/profile_info_cache.h (right):

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/profile...
chrome/browser/profiles/profile_info_cache.h:65: base::string16
GetUserNameOfProfileAtIndex(size_t index) const override;
like below, capitalization is slightly off here --- this should be
GetUsernameOfProfileAtIndex

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/profile...
chrome/browser/profiles/profile_info_cache.h:75: std::string
GetGAIAIdOfProfileAtIndex(size_t index) const override;
maybe not necessary to change in this patch, but this should be
GetGaiaIdOfProfileAtIndex. See
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Names

Please consider fixing these all in a different CL.

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/signin/inline_login_handler_impl.cc (right):

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/ui/webu...
chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:572: // For backward
compatibility, need to also check the UserName of the
nit: s/UserName/username

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/ui/webu...
chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:573: // profile,
since the GaiaId may not have been set yet for the
s/GaiaId/GAIA ID

[Evan Stade, 2015-05-11 17:28:23]

otherwise, webui lgtm

[sky, 2015-05-11 17:45:17]

LGTM

[Roger Tawa OOO till Jul 10th, 2015-05-11 20:34:36]

Thanks Evan, Xiyuan.  See below for comments.

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/chromeo...
File chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc (right):

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/chromeo...
chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc:167:
cache->GetUserDataDir().AppendASCII("p2"), supervised_name, std::string(),
On 2015/05/11 16:38:17, xiyuan wrote:
> nit: std::string() -> "fake_gaia_id" for better readability?

This is a supervised user test case, so there is no gaia-id/username.  So I
think std::string() is correct.

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/profile...
File chrome/browser/profiles/profile_info_cache.h (right):

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/profile...
chrome/browser/profiles/profile_info_cache.h:65: base::string16
GetUserNameOfProfileAtIndex(size_t index) const override;
On 2015/05/11 17:11:54, Evan Stade wrote:
> like below, capitalization is slightly off here --- this should be
> GetUsernameOfProfileAtIndex

See comment below.

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/profile...
chrome/browser/profiles/profile_info_cache.h:75: std::string
GetGAIAIdOfProfileAtIndex(size_t index) const override;
On 2015/05/11 17:11:54, Evan Stade wrote:
> maybe not necessary to change in this patch, but this should be
> GetGaiaIdOfProfileAtIndex. See
>
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Names
> 
> Please consider fixing these all in a different CL.

I had actually done that initially, but then saw the existing methods
GetGAIAPictureOfProfileAtIndex(), IsUsingGAIAPictureOfProfileAtIndex(),
SetGAIANameOfProfileAtIndex().  So I decided to be self consistent with this
class.  But I agree that this does not conform to naming standard.

This CL is big enough, so opened crbug.com/486887 to track.

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/signin/inline_login_handler_impl.cc (right):

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/ui/webu...
chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:572: // For backward
compatibility, need to also check the UserName of the
On 2015/05/11 17:11:54, Evan Stade wrote:
> nit: s/UserName/username

Done.

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/ui/webu...
chrome/browser/ui/webui/signin/inline_login_handler_impl.cc:573: // profile,
since the GaiaId may not have been set yet for the
On 2015/05/11 17:11:54, Evan Stade wrote:
> s/GaiaId/GAIA ID

Done.

[Evan Stade, 2015-05-11 20:35:38]

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/profile...
File chrome/browser/profiles/profile_info_cache.h (right):

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/profile...
chrome/browser/profiles/profile_info_cache.h:75: std::string
GetGAIAIdOfProfileAtIndex(size_t index) const override;
On 2015/05/11 20:34:36, Roger Tawa wrote:
> On 2015/05/11 17:11:54, Evan Stade wrote:
> > maybe not necessary to change in this patch, but this should be
> > GetGaiaIdOfProfileAtIndex. See
> >
>
https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Names
> > 
> > Please consider fixing these all in a different CL.
> 
> I had actually done that initially, but then saw the existing methods
> GetGAIAPictureOfProfileAtIndex(), IsUsingGAIAPictureOfProfileAtIndex(),
> SetGAIANameOfProfileAtIndex().  So I decided to be self consistent with this
> class.  But I agree that this does not conform to naming standard.
> 
> This CL is big enough, so opened crbug.com/486887 to track.

thanks

[xiyuan, 2015-05-11 21:30:27]

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/chromeo...
File chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc (right):

https://codereview.chromium.org/1117453002/diff/320001/chrome/browser/chromeo...
chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc:167:
cache->GetUserDataDir().AppendASCII("p2"), supervised_name, std::string(),
On 2015/05/11 20:34:36, Roger Tawa wrote:
> On 2015/05/11 16:38:17, xiyuan wrote:
> > nit: std::string() -> "fake_gaia_id" for better readability?
> 
> This is a supervised user test case, so there is no gaia-id/username.  So I
> think std::string() is correct.

I see. Ignore my comment then. :)

[Roger Tawa OOO till Jul 10th, 2015-05-11 21:41:48]

The CQ bit was checked by [email protected]

[Roger Tawa OOO till Jul 10th, 2015-05-11 21:41:49]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected], [email protected], [email protected], [email protected],
[email protected], [email protected]
Link to the patchset: https://codereview.chromium.org/1117453002/#ps340001
(title: "Fix comments")

[commit-bot: I haz the power, 2015-05-11 21:44:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1117453002/340001

[commit-bot: I haz the power, 2015-05-11 21:58:29]

Committed patchset #8 (id:340001)

[commit-bot: I haz the power, 2015-05-11 21:59:25]

Patchset 8 (id:??) landed as
https://crrev.com/e2265960703ea8840d20966ce38442e9aaa8eb0a
Cr-Commit-Position: refs/heads/master@{#329244}