Enable to touch a directory on Windows

On Windows, current implementation fails touching directories because it cannot open directories without specific flag |FILE_FLAG_BACKUP_SEMANTICS|.

This patch makes it possible to touch them by setting the flag.


BUG=136490, 137807
TEST=content_unittests --gtest_filter=\*MoveDirectory\*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165338

[nhiroki, 2012-10-19 09:14:17]

PTAL, thanks!

[tzik, 2012-10-19 09:57:35]

Thanks! LGTM!
Please ask base/ OWNERS to review this.

http://codereview.chromium.org/11198079/diff/1006/base/file_util.cc
File base/file_util.cc (right):

http://codereview.chromium.org/11198079/diff/1006/base/file_util.cc#newcode209
base/file_util.cc:209: if (DirectoryExists(path))
Please add { and }.

[nhiroki, 2012-10-22 02:28:09]

Thanks for reviewing!

http://codereview.chromium.org/11198079/diff/1006/base/file_util.cc
File base/file_util.cc (right):

http://codereview.chromium.org/11198079/diff/1006/base/file_util.cc#newcode209
base/file_util.cc:209: if (DirectoryExists(path))
On 2012/10/19 09:57:35, tzik wrote:
> Please add { and }.

Done.

[nhiroki, 2012-10-22 02:38:24]

+brettw@, could you review base/ as OWNER? Thanks!

[nhiroki, 2012-10-29 05:09:02]

brettw@, just a friendly ping.
I need OWNER review in base/, could you take a look? thanks!

[brettw, 2012-10-29 18:35:39]

I'm going to redirect my review to cpu. LGTM to make the CQ happy, but please
wait for Carlos' review before checking in.

[cpu_(ooo_6.6-7.5), 2012-10-29 22:55:06]

question, what do you get currenty before your patch if you pass a directory?
base::kInvalidPlatformFileValue ?

http://codereview.chromium.org/11198079/diff/17001/base/file_util.cc
File base/file_util.cc (right):

http://codereview.chromium.org/11198079/diff/17001/base/file_util.cc#newcode207
base/file_util.cc:207: 
instead of having 3 CreatePlatformFile calls, have a single one like
   base::CreatePlatformFile(path, flags, NULL, NULL);

and have the flags be different for the different cases

[nhiroki, 2012-10-31 04:22:46]

Thanks for reviewing!

On 2012/10/29 22:55:06, cpu wrote:
> question, what do you get currenty before your patch if you pass a directory?
> base::kInvalidPlatformFileValue ?

Yes, we can get base::kInvalidPlatformFileValue before my patch.

http://codereview.chromium.org/11198079/diff/17001/base/file_util.cc
File base/file_util.cc (right):

http://codereview.chromium.org/11198079/diff/17001/base/file_util.cc#newcode207
base/file_util.cc:207: 
On 2012/10/29 22:55:06, cpu wrote:
> instead of having 3 CreatePlatformFile calls, have a single one like
>    base::CreatePlatformFile(path, flags, NULL, NULL);
> 
> and have the flags be different for the different cases
> 
> 

Done.

[cpu_(ooo_6.6-7.5), 2012-10-31 22:27:46]

lgtm

[commit-bot: I haz the power, 2012-11-01 00:31:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11198079/37001

[commit-bot: I haz the power, 2012-11-01 03:32:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11198079/37001

[commit-bot: I haz the power, 2012-11-01 09:08:57]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-01 09:18:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11198079/37001

[commit-bot: I haz the power, 2012-11-01 11:12:40]

Retried try job too often for step(s) interactive_ui_tests