Change Cdm::GetCurrentWallTimeMs() to GetCurrentWallTimeInSeconds().

Change Cdm::GetCurrentWallTimeMs() to GetCurrentWallTimeInSeconds().

Since pp::Module::Get()->core()->GetTime() returns seconds, not ms.

Also updated clear key system to use CdmHost to implement a simple heart beat system for testing purpose.

BUG=none
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165416

[xhwang, 2012-10-29 22:06:15]

PTAL!

[Ami GONE FROM CHROMIUM, 2012-10-29 22:15:41]

lgtm

[xhwang, 2012-10-30 00:26:59]

fischman: Added more code in clearkey cdm. PTAL again.

shadi: With this change, the CDM will send out heart beat key messages every 5
seconds. I assume all of our tests don't parse key messages at all and hence
shouldn't be broken by this. Actually it'll be nice to test if key messages are
sent out periodically. When you do that, I can shorten the heart beat period
since our test video is only 2 seconds long.

[xhwang, 2012-10-30 00:52:09]

fischman: I just chatted with shadi offline and now we are calling "AddKey"
whenever we receive a KeyMessage. So this new code in ClearKeyCdm will mess up
the tests. I'll probably just commit patch set 1 first, then commit patch set 2
after we fixed the tests.

[shadi, 2012-10-30 00:52:55]

On 2012/10/30 00:26:59, xhwang wrote:
> fischman: Added more code in clearkey cdm. PTAL again.
> 
> shadi: With this change, the CDM will send out heart beat key messages every 5
> seconds. I assume all of our tests don't parse key messages at all and hence
> shouldn't be broken by this. Actually it'll be nice to test if key messages
are
> sent out periodically. When you do that, I can shorten the heart beat period
> since our test video is only 2 seconds long.

xhwang: we use the first key message to call webkitAddKey(). So this heart beat
will call webkitAddKey() with garbage.  If the key message is parsable, we can
check if it is a generate key request message before adding the key.  Similarly,
we can check if it is a heart beat message to test your changes?

[ddorwin, 2012-10-30 08:44:28]

Patch 1 is fine (remove explicit). Patch 2 needs a test fix.

shadi: You can probably just treat the first as the license request and
subsequent as messages. Make sure you receive at least one message beyond the
license request.

http://codereview.chromium.org/11340021/diff/4001/webkit/media/crypto/ppapi/c...
File webkit/media/crypto/ppapi/clear_key_cdm.cc (right):

http://codereview.chromium.org/11340021/diff/4001/webkit/media/crypto/ppapi/c...
webkit/media/crypto/ppapi/clear_key_cdm.cc:272: msg->set_session_id(NULL, 0);
We should probably store the session_id so it can be returned.

http://codereview.chromium.org/11340021/diff/4001/webkit/media/crypto/ppapi/c...
File webkit/media/crypto/ppapi/clear_key_cdm.h (right):

http://codereview.chromium.org/11340021/diff/4001/webkit/media/crypto/ppapi/c...
webkit/media/crypto/ppapi/clear_key_cdm.h:45: explicit
ClearKeyCdm(cdm::Allocator* allocator, cdm::CdmHost* cdm_host);
remove explicit

[xhwang, 2012-11-01 00:47:47]

Move patch set 2 to issue 11368023 so that I can commit patch set 1. ddorwin's
comments will be resolved there. I'll delete patch set 2 shortly.

[commit-bot: I haz the power, 2012-11-01 04:14:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11340021/12001

[commit-bot: I haz the power, 2012-11-01 10:43:15]

Retried try job too often for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2012-11-01 10:47:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/11340021/12001

[commit-bot: I haz the power, 2012-11-01 11:40:32]

Retried try job too often for step(s) interactive_ui_tests