About box development....

About box development.
BUG=http://codereview.chromium.org/112044

Note pieces of chrome.gyp come from a different CL
(keystone_glue work associated with this).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16545

[pink (ping after 24hrs), 2009-05-20 14:25:35]

Good overall, lots of style nits.

http://codereview.chromium.org/113614/diff/1/8
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/113614/diff/1/8#newcode298
Line 298: aboutController_.reset([[AboutWindowController alloc]
initWithWindowNibName:@"About"]);
80cols

http://codereview.chromium.org/113614/diff/1/8#newcode307
Line 307: 
omit blank line

http://codereview.chromium.org/113614/diff/1/5
File chrome/browser/cocoa/about_controller_unittest.mm (right):

http://codereview.chromium.org/113614/diff/1/5#newcode1
Line 1: // TODO
bug filed?

http://codereview.chromium.org/113614/diff/1/7
File chrome/browser/cocoa/about_window_controller.h (right):

http://codereview.chromium.org/113614/diff/1/7#newcode13
Line 13: @interface AboutWindowController :
NSWindowController<KeystoneGlueCallbacks> {
class needs a comment. purpose, assumptions, how it's used, etc.

http://codereview.chromium.org/113614/diff/1/7#newcode21
Line 21: BOOL updateTriggered_;    // Has an update ever been triggered?
same-line comments are 2 spaces after the semicolon

http://codereview.chromium.org/113614/diff/1/6
File chrome/browser/cocoa/about_window_controller.mm (right):

http://codereview.chromium.org/113614/diff/1/6#newcode30
Line 30: NSString* display = @"No updates are available.";
we already have a bunch of these strings in generated_resources.grd. This one
could be IDS_UPGRADE_ALREADY_UP_TO_DATE. Maybe poke around in there, and that'll
save us from having to come back for l10n? Then again, maybe those strings don't
work at all for us.

http://codereview.chromium.org/113614/diff/1/6#newcode34
Line 34: [NSString stringWithFormat:@"Version %@ is available for update.",
continuation indents 4 spaces.

http://codereview.chromium.org/113614/diff/1/6#newcode36
Line 36: @"A new version is available.";
IDS_UPGRADE_AVAILABLE

http://codereview.chromium.org/113614/diff/1/6#newcode41
Line 41: - (id)initWithWindowNibName:(NSString*)nibName {
i'd move init and awakeFromNib up to be the first 2 methods in the impl. Those,
and dealloc if present, are ones we're used to seeing at the top.

http://codereview.chromium.org/113614/diff/1/6#newcode51
Line 51: FileVersionInfo::CreateFileVersionInfoForCurrentModule());
continuations indented 4 spaces.

http://codereview.chromium.org/113614/diff/1/6#newcode58
Line 58: // it for the "checkForUpdate" case.
i don't see any reason to remove it. there will always be cases where the
network is slow to respond, or entirely unresponsive. I'd just remove the TODO.

http://codereview.chromium.org/113614/diff/1/6#newcode77
Line 77: - (void)updateCompleted:(BOOL)successful installs:(int)installs {
function-level comment needed.

http://codereview.chromium.org/113614/diff/1/6#newcode78
Line 78: [spinner_ stopAnimation:self];
this whole method looks like it's indented too far.

http://codereview.chromium.org/113614/diff/1/6#newcode79
Line 79: NSString* display = ((successful && installs) ?
you can drop the extra layer of parens

[John Grabowski, 2009-05-20 18:11:25]

Note add of about_windmow_controller_unittest.mm and removal of (empty)
about_window_unittest.mm

http://codereview.chromium.org/113614/diff/1/8
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/113614/diff/1/8#newcode298
Line 298: aboutController_.reset([[AboutWindowController alloc]
initWithWindowNibName:@"About"]);
On 2009/05/20 14:25:35, pink wrote:
> 80cols

trimmed

http://codereview.chromium.org/113614/diff/1/8#newcode307
Line 307: 
On 2009/05/20 14:25:35, pink wrote:
> omit blank line

removed

http://codereview.chromium.org/113614/diff/1/5
File chrome/browser/cocoa/about_controller_unittest.mm (right):

http://codereview.chromium.org/113614/diff/1/5#newcode1
Line 1: // TODO
On 2009/05/20 14:25:35, pink wrote:
> bug filed?

Ugh... svn mixup.  The real file, as referenced in chrome.gyp, is named
about_window_controller_unittest.mm, not about_controller_unittest.mm.
Re-uped.

http://codereview.chromium.org/113614/diff/1/7
File chrome/browser/cocoa/about_window_controller.h (right):

http://codereview.chromium.org/113614/diff/1/7#newcode13
Line 13: @interface AboutWindowController :
NSWindowController<KeystoneGlueCallbacks> {
On 2009/05/20 14:25:35, pink wrote:
> class needs a comment. purpose, assumptions, how it's used, etc.

Added

http://codereview.chromium.org/113614/diff/1/7#newcode21
Line 21: BOOL updateTriggered_;    // Has an update ever been triggered?
On 2009/05/20 14:25:35, pink wrote:
> same-line comments are 2 spaces after the semicolon

Oh; I'm such a big fan of 2 spaces I did it twice!
2-ified.

http://codereview.chromium.org/113614/diff/1/6
File chrome/browser/cocoa/about_window_controller.mm (right):

http://codereview.chromium.org/113614/diff/1/6#newcode34
Line 34: [NSString stringWithFormat:@"Version %@ is available for update.",
On 2009/05/20 14:25:35, pink wrote:
> continuation indents 4 spaces.

indented

http://codereview.chromium.org/113614/diff/1/6#newcode41
Line 41: - (id)initWithWindowNibName:(NSString*)nibName {
On 2009/05/20 14:25:35, pink wrote:
> i'd move init and awakeFromNib up to be the first 2 methods in the impl.
Those,
> and dealloc if present, are ones we're used to seeing at the top.

Arranged.

http://codereview.chromium.org/113614/diff/1/6#newcode51
Line 51: FileVersionInfo::CreateFileVersionInfoForCurrentModule());
On 2009/05/20 14:25:35, pink wrote:
> continuations indented 4 spaces.

4ified.

http://codereview.chromium.org/113614/diff/1/6#newcode58
Line 58: // it for the "checkForUpdate" case.
On 2009/05/20 14:25:35, pink wrote:
> i don't see any reason to remove it. there will always be cases where the
> network is slow to respond, or entirely unresponsive. I'd just remove the
TODO.

Removed (TODO).

http://codereview.chromium.org/113614/diff/1/6#newcode77
Line 77: - (void)updateCompleted:(BOOL)successful installs:(int)installs {
On 2009/05/20 14:25:35, pink wrote:
> function-level comment needed.

This is an implementation of the KeystoneGlueCallbacks protocol defined in
keystone_glue.h (http://codereview.chromium.org/113613) which is documented.
Sorry to split up the CL like this but I'm trying to not make them too big.
Comment added.

http://codereview.chromium.org/113614/diff/1/6#newcode78
Line 78: [spinner_ stopAnimation:self];
On 2009/05/20 14:25:35, pink wrote:
> this whole method looks like it's indented too far.

Abs right; fixed.

http://codereview.chromium.org/113614/diff/1/6#newcode79
Line 79: NSString* display = ((successful && installs) ?
On 2009/05/20 14:25:35, pink wrote:
> you can drop the extra layer of parens

I wanted things to line up nice.

[pink (ping after 24hrs), 2009-05-20 18:36:58]

LGTM

http://codereview.chromium.org/113614/diff/1010/1014
File chrome/browser/cocoa/about_window_controller_unittest.mm (right):

http://codereview.chromium.org/113614/diff/1010/1014#newcode49
Line 49: NSString *upToDate = [[about_window_controller_ upToDateTextField]
stringValue];
80cols