Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 113906: Fix a deleted memory read with the infobars (Closed)

Created:
11 years, 7 months ago by jcampan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Some ui tests would crash when the browser was closed. The problem was related to an infobar (the default browser one) showing. When the tab is closed, InfoBarClosed is called on the infobar delegates, triggering a delete of the delegate. Then a notification that the tab is destroyed is sent, causing the tab contents to layout its infobars accessing the deleted delegates. BUG=12668 TEST=All UI tests should pass (especially the LoginPromptTest ones). Make IE your default browser, start Chrome. The default browser infobar should show. Close the tab. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17021

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/browser/tab_contents/tab_contents.cc View 1 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
11 years, 7 months ago (2009-05-27 17:39:00 UTC) #1
Ben Goodger (Google)
11 years, 7 months ago (2009-05-27 18:53:26 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698