Windows icon loader refactor in preparation for port.

Windows icon loader refactor in preparation for port.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15577

[Evan Stade, 2009-05-07 03:49:07]

Hi, it's me again. I'm back with more!

The intent is to put icon_loader_{linux,mac} alongside icon_loader_win. You'll
notice I deleted some more dead code and fused IconLoaderProcessor with
IconLoader.

[idana, 2009-05-07 18:06:19]

Good stuff!

I have a few nit comments.

Also, I noticed that there are a couple of lint errors so please fix them.

http://codereview.chromium.org/115056/diff/15/1015
File chrome/browser/icon_loader.h (right):

http://codereview.chromium.org/115056/diff/15/1015#newcode45
Line 45: // Factory method for return a platform specific IconLoad.
"for return" -> "which returns"

http://codereview.chromium.org/115056/diff/15/1014
File chrome/browser/icon_loader_win.h (right):

http://codereview.chromium.org/115056/diff/15/1014#newcode12
Line 12: class IconLoaderWin : public IconLoader {
The name of the class is pretty self documentary, but it'd be nice to put a
short description above the class declaration to explain how it implements the
interface. Please feel free to ignore this comment if you think that such
description will be redundant given the class name.

http://codereview.chromium.org/115056/diff/15/1014#newcode14
Line 14: explicit IconLoaderWin(const FilePath& path, IconSize size,
You don't need 'explicit' here.

[Evan Stade, 2009-05-07 18:41:51]

On 2009/05/07 18:06:19, idana wrote:
> Good stuff!
> 
> I have a few nit comments.
> 
> Also, I noticed that there are a couple of lint errors so please fix them.

I believe there's a bug with the linter where it doesn't recognize new lines on
added files.

> 
> http://codereview.chromium.org/115056/diff/15/1015
> File chrome/browser/icon_loader.h (right):
> 
> http://codereview.chromium.org/115056/diff/15/1015#newcode45
> Line 45: // Factory method for return a platform specific IconLoad.
> "for return" -> "which returns"

done.

> 
> http://codereview.chromium.org/115056/diff/15/1014
> File chrome/browser/icon_loader_win.h (right):
> 
> http://codereview.chromium.org/115056/diff/15/1014#newcode12
> Line 12: class IconLoaderWin : public IconLoader {
> The name of the class is pretty self documentary, but it'd be nice to put a
> short description above the class declaration to explain how it implements the
> interface. Please feel free to ignore this comment if you think that such
> description will be redundant given the class name.
> 
> http://codereview.chromium.org/115056/diff/15/1014#newcode14
> Line 14: explicit IconLoaderWin(const FilePath& path, IconSize size,
> You don't need 'explicit' here.

done.

[idana, 2009-05-07 20:17:42]

LGTM