Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1162923005: Use SequencedSocketData in SpdyHttpStreamTest. (Closed)

Created:
5 years, 6 months ago by Bence
Modified:
5 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SequencedSocketData in SpdyHttpStreamTest. Use SequencedSocketData instead of DeterministicSocketData in SpdyHttpStreamTest. BUG=492694 Committed: https://crrev.com/78edcd5e7f6eace6313e22625163b61c96371495 Cr-Commit-Position: refs/heads/master@{#332817}

Patch Set 1 #

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -93 lines) Patch
M net/spdy/spdy_http_stream_unittest.cc View 1 19 chunks +49 lines, -93 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 6 months ago (2015-06-02 17:22:33 UTC) #2
Ryan Hamilton
lgtm
5 years, 6 months ago (2015-06-03 23:37:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162923005/20001
5 years, 6 months ago (2015-06-04 11:14:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-04 11:34:12 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 11:35:12 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78edcd5e7f6eace6313e22625163b61c96371495
Cr-Commit-Position: refs/heads/master@{#332817}

Powered by Google App Engine
This is Rietveld 408576698