Add a chrome://flag for the App Info dialog on Mac

Add a chrome://flag for the App Info dialog on Mac

The dialog is accessible from chrome://apps or chrome://extensions.
Replaces the "View in Webstore" option with a more powerful,
offline-enabled dialog (which has its own webstore link).

It's currently coupled to --enable-mac-views-app-list, but the views app
list on Mac is lower priority. We want to prep the App Info dialog for
QA.

Adds --{enable,disable}-app-info-dialog-mac, and an enable/disable
chrome://flag. Hide it on everything that isn't Mac, since the app info
dialog is on by default there, and can't be disabled.

BUG=485854
Committed: https://crrev.com/cafe3b98185219ce03e20f2983f95ff31f044b08
Cr-Commit-Position: refs/heads/master@{#332703}

[tapted, 2015-06-03 04:07:12]

[email protected] changed reviewers:
+ [email protected]

[tapted, 2015-06-03 04:07:13]

Hi Ben, please take a look

[benwells, 2015-06-03 04:30:42]

lgtm with some comments

https://codereview.chromium.org/1166823002/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1166823002/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:6897: +          Makes the toolkit-views
based App Info dialog accessible from chrome://apps or chrome://extensions in
place of the native extension permissions dialog, or the Details link (to the
webstore).
I can't parse what 'or the Details link (to the WebStore)' is referring to.

https://codereview.chromium.org/1166823002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
(left):

https://codereview.chromium.org/1166823002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc:36: return
app_list::switches::IsMacViewsAppListListEnabled();
(not related to this patch) why is this ListList?

https://codereview.chromium.org/1166823002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
(right):

https://codereview.chromium.org/1166823002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc:39: bool
GetSwitchFromCommandLine() {
Nit: rename to IsAppInfoDialogMacEnabled or something similar.

[tapted, 2015-06-03 05:00:21]

https://codereview.chromium.org/1166823002/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1166823002/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:6897: +          Makes the toolkit-views
based App Info dialog accessible from chrome://apps or chrome://extensions in
place of the native extension permissions dialog, or the Details link (to the
webstore).
On 2015/06/03 04:30:41, benwells wrote:
> I can't parse what 'or the Details link (to the WebStore)' is referring to.

updated to "or the details link (which is a link to the Web Store)"

(also tweaked some proper nouns to assist translations)

https://codereview.chromium.org/1166823002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
(left):

https://codereview.chromium.org/1166823002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc:36: return
app_list::switches::IsMacViewsAppListListEnabled();
On 2015/06/03 04:30:41, benwells wrote:
> (not related to this patch) why is this ListList?

It is Frerman, "L'ist" for "the is".

(fix: https://codereview.chromium.org/1143083009 - I'll rebase this after that
lands)

https://codereview.chromium.org/1166823002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
(right):

https://codereview.chromium.org/1166823002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc:39: bool
GetSwitchFromCommandLine() {
On 2015/06/03 04:30:41, benwells wrote:
> Nit: rename to IsAppInfoDialogMacEnabled or something similar.

Done.

[tapted, 2015-06-03 09:29:37]

[email protected] changed reviewers:
+ [email protected]

[tapted, 2015-06-03 09:29:37]

+isherman for histograms OWNERS

[Ilya Sherman, 2015-06-03 20:45:01]

histograms.xml lgtm

[tapted, 2015-06-03 21:21:22]

The CQ bit was checked by [email protected]

[tapted, 2015-06-03 21:21:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
[email protected]
Link to the patchset: https://codereview.chromium.org/1166823002/#ps80001
(title: "Rebase after typo fix")

[commit-bot: I haz the power, 2015-06-03 21:23:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1166823002/80001

[commit-bot: I haz the power, 2015-06-03 21:57:48]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-03 21:59:46]

Patchset 5 (id:??) landed as
https://crrev.com/cafe3b98185219ce03e20f2983f95ff31f044b08
Cr-Commit-Position: refs/heads/master@{#332703}