Issue 11684002: Don't scale mask image for new tab button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11684002: Don't scale mask image for new tab button. (Closed)

Created:
7 years, 12 months ago by oshima

Modified:
7 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, rsesek+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't scale mask image for new tab button. MatchScale's 2x routine uses canvas which can't scale mask image. This routine should be gone, so I fixed it in tab_strip, rather than fixing this routine. I'll flip the default value of the flag "scaling-in-image-skia-operation" so that mismatch will result in CHECK failure. BUG=163372 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175394

Patch Set 1 #

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/ui/views/tabs/tab_strip.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	ui/gfx/image/image_skia_operations.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/11684002/1

7 years, 11 months ago (2013-01-07 18:36:06 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_aura for step(s) interactive_ui_tests

7 years, 11 months ago (2013-01-07 21:08:45 UTC) #4

oshima

7 years, 11 months ago (2013-01-07 22:04:19 UTC) #5

On 2013/01/07 21:08:45, I haz the power (commit-bot) wrote:
> Retried try job too often on win_aura for step(s) interactive_ui_tests

Looks like the failures has nothing to do with the change (other CQ jobs have
the same failures). dcommitting.

Expand Messages | Collapse Messages