[MediaRouter] Update MR-2-Extension's PostMessage to return boolean.

[MediaRouter] Update MR-2-Extension's PostMessage to return boolean.

This is then consistent with Blink-2-MR mojo interface.

Committed: https://crrev.com/d0702bcea3520e2f3ce751408f897b06afd9f1c0
Cr-Commit-Position: refs/heads/master@{#334109}

[haibinlu, 2015-06-11 00:53:09]

[email protected] changed reviewers:
+ [email protected], [email protected]

[mark a. foltz, 2015-06-11 05:04:29]

https://codereview.chromium.org/1177073003/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/media_router.h (right):

https://codereview.chromium.org/1177073003/diff/1/chrome/browser/media/router...
chrome/browser/media/router/media_router.h:54: virtual void PostMessage(const
MediaRoute::Id& route_id,
We should rename this SendMessage to be more consistent with send() in the
Presentation API.

https://codereview.chromium.org/1177073003/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/test_helper.h (left):

https://codereview.chromium.org/1177073003/diff/1/chrome/browser/media/router...
chrome/browser/media/router/test_helper.h:51: MOCK_METHOD2(PostMessage,
This file could be named mojo_test_helper.h to better explain why we have two
similar sets of mock methods.

https://codereview.chromium.org/1177073003/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/media_router_bindings.js (right):

https://codereview.chromium.org/1177073003/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/media_router_bindings.js:457: // TODO(mfoltz):
Remove extraInfoJson if no longer needed.
Is it possible to take care of this now?

[haibinlu, 2015-06-11 17:37:18]

PTAL

https://codereview.chromium.org/1177073003/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/media_router.h (right):

https://codereview.chromium.org/1177073003/diff/1/chrome/browser/media/router...
chrome/browser/media/router/media_router.h:54: virtual void PostMessage(const
MediaRoute::Id& route_id,
On 2015/06/11 05:04:29, mark a. foltz wrote:
> We should rename this SendMessage to be more consistent with send() in the
> Presentation API.

Done.

https://codereview.chromium.org/1177073003/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/test_helper.h (left):

https://codereview.chromium.org/1177073003/diff/1/chrome/browser/media/router...
chrome/browser/media/router/test_helper.h:51: MOCK_METHOD2(PostMessage,
On 2015/06/11 05:04:29, mark a. foltz wrote:
> This file could be named mojo_test_helper.h to better explain why we have two
> similar sets of mock methods.

presentation_service_delegate_impl test also uses some methods here.

https://codereview.chromium.org/1177073003/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/media_router_bindings.js (right):

https://codereview.chromium.org/1177073003/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/media_router_bindings.js:457: // TODO(mfoltz):
Remove extraInfoJson if no longer needed.
On 2015/06/11 05:04:29, mark a. foltz wrote:
> Is it possible to take care of this now?

Done.

[mark a. foltz, 2015-06-11 18:48:33]

lgtm

https://codereview.chromium.org/1177073003/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/media_router_bindings.js (right):

https://codereview.chromium.org/1177073003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/media_router_bindings.js:454:
MediaRouter.prototype.sendMessage = function(
It seems odd that the Promise should be resolved here.  Perhaps this function
should return the Promise to the caller so it can chain off of it.

[haibinlu, 2015-06-11 21:12:47]

[email protected] changed reviewers:
+ [email protected]

[haibinlu, 2015-06-11 21:12:48]

Hi, Ken, Do you mind reviewing changes in
extensions/renderer/resources/media_router_bindings.js? Thanks!

[Ken Rockot(use gerrit already), 2015-06-11 21:22:05]

lgtm with some comments

https://codereview.chromium.org/1177073003/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/media_router_bindings.js (right):

https://codereview.chromium.org/1177073003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/media_router_bindings.js:452: *  or false on
failure.
super nitty style nit: should indent 4 spaces from the @

  * @return ...
  *     or false ...

https://codereview.chromium.org/1177073003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/media_router_bindings.js:454:
MediaRouter.prototype.sendMessage = function(
On 2015/06/11 18:48:33, mark a. foltz wrote:
> It seems odd that the Promise should be resolved here.  Perhaps this function
> should return the Promise to the caller so it can chain off of it.
> 

I agree. A Promise resolving/rejecting is effectively already a boolean result,
so doing this only serves to hide potential failure details in case of
rejection.

[Kevin M, 2015-06-11 22:45:23]

[email protected] changed reviewers:
+ [email protected]

[Kevin M, 2015-06-11 22:45:24]

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/media_router.h (right):

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router.h:32: using SendMessageCallback =
base::Callback<void(bool sent)>;
Make this a child of MediaRouter

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/media_router.mojom (right):

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router.mojom:97: // Sends |message| with
optional |extra_info_json| via the media route
extra_info_json is no more.

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router.mojom:99: // If the operation was
sucessfull, |sent| is true; otherwise it is false.
extra 'l' in successful

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/media_router_mojo_impl_unittest.cc (right):

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router_mojo_impl_unittest.cc:285: const
interfaces::MediaRouter::SendMessageCallback & cb) { cb.Run(true); }));
80col

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router_mojo_impl_unittest.cc:287:
router()->SendMessage(kRouteId, kMessage, base::Bind(&AssertPostMessageResult,
true));
This is potentially buggy because there are no dtor-time mock expectation checks
- the test will still succeed if the callback is never invoked.

I recommend creating a simple mock class w/ MOCK_METHOD and setting expectations
on it. Then pass a bound callback using the mocked fn to SendMessage.

[haibinlu, 2015-06-11 22:46:23]

https://codereview.chromium.org/1177073003/diff/20001/extensions/renderer/res...
File extensions/renderer/resources/media_router_bindings.js (right):

https://codereview.chromium.org/1177073003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/media_router_bindings.js:452: *  or false on
failure.
On 2015/06/11 21:22:04, Ken Rockot wrote:
> super nitty style nit: should indent 4 spaces from the @
> 
>   * @return ...
>   *     or false ...

Done.

https://codereview.chromium.org/1177073003/diff/20001/extensions/renderer/res...
extensions/renderer/resources/media_router_bindings.js:454:
MediaRouter.prototype.sendMessage = function(
On 2015/06/11 21:22:04, Ken Rockot wrote:
> On 2015/06/11 18:48:33, mark a. foltz wrote:
> > It seems odd that the Promise should be resolved here.  Perhaps this
function
> > should return the Promise to the caller so it can chain off of it.
> > 
> 
> I agree. A Promise resolving/rejecting is effectively already a boolean
result,
> so doing this only serves to hide potential failure details in case of
> rejection.

For mojo method that returns a value,  mojo generates Promise as return value at
Javascript side, and callback at c++ side. I did not find a way to tell mojo how
to convert a rejected promise into proper return value for the callback.

[haibinlu, 2015-06-11 22:46:34]

The CQ bit was checked by [email protected]

[haibinlu, 2015-06-11 22:46:34]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected]
Link to the patchset: https://codereview.chromium.org/1177073003/#ps40001
(title: " ")

[haibinlu, 2015-06-11 22:47:33]

The CQ bit was unchecked by [email protected]

[haibinlu, 2015-06-11 23:05:23]

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/media_router.h (right):

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router.h:32: using SendMessageCallback =
base::Callback<void(bool sent)>;
On 2015/06/11 22:45:24, Kevin M wrote:
> Make this a child of MediaRouter

Done.

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/media_router.mojom (right):

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router.mojom:97: // Sends |message| with
optional |extra_info_json| via the media route
On 2015/06/11 22:45:24, Kevin M wrote:
> extra_info_json is no more.

removed

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router.mojom:99: // If the operation was
sucessfull, |sent| is true; otherwise it is false.
On 2015/06/11 22:45:24, Kevin M wrote:
> extra 'l' in successful

Done.

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
File chrome/browser/media/router/media_router_mojo_impl_unittest.cc (right):

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router_mojo_impl_unittest.cc:285: const
interfaces::MediaRouter::SendMessageCallback & cb) { cb.Run(true); }));
On 2015/06/11 22:45:24, Kevin M wrote:
> 80col

Done.

https://codereview.chromium.org/1177073003/diff/20001/chrome/browser/media/ro...
chrome/browser/media/router/media_router_mojo_impl_unittest.cc:287:
router()->SendMessage(kRouteId, kMessage, base::Bind(&AssertPostMessageResult,
true));
On 2015/06/11 22:45:24, Kevin M wrote:
> This is potentially buggy because there are no dtor-time mock expectation
checks
> - the test will still succeed if the callback is never invoked.
> 
> I recommend creating a simple mock class w/ MOCK_METHOD and setting
expectations
> on it. Then pass a bound callback using the mocked fn to SendMessage.

Good catch. Done.

[haibinlu, 2015-06-11 23:05:46]

The CQ bit was checked by [email protected]

[haibinlu, 2015-06-11 23:05:47]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected]
Link to the patchset: https://codereview.chromium.org/1177073003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-06-11 23:07:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1177073003/60001

[commit-bot: I haz the power, 2015-06-12 00:09:31]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2015-06-12 00:09:32]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[haibinlu, 2015-06-12 00:47:23]

The CQ bit was checked by [email protected]

[haibinlu, 2015-06-12 00:47:23]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected]
Link to the patchset: https://codereview.chromium.org/1177073003/#ps80001
(title: "Rename SendMessage to SendRouteMessage")

[commit-bot: I haz the power, 2015-06-12 00:48:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1177073003/80001

[commit-bot: I haz the power, 2015-06-12 01:59:06]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-12 02:00:55]

Patchset 5 (id:??) landed as
https://crrev.com/d0702bcea3520e2f3ce751408f897b06afd9f1c0
Cr-Commit-Position: refs/heads/master@{#334109}