Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1181283007: Change the QUICStreamSequencerTest to test the sequencer interface, (Closed)

Created:
5 years, 6 months ago by ramant (doing other things)
Modified:
5 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Introduce_tests_96120706
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the QUICStreamSequencerTest to test the sequencer interface, rather than reaching into the implementation. relnote: N/A. Test only change. Merge internal change: 96134592 [email protected]

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -54 lines) Patch
M net/quic/quic_stream_sequencer.h View 2 chunks +7 lines, -7 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 9 chunks +39 lines, -43 lines 0 comments Download
M net/quic/test_tools/quic_stream_sequencer_peer.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_stream_sequencer_peer.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
5 years, 6 months ago (2015-06-17 21:58:00 UTC) #1
Ryan Hamilton
5 years, 6 months ago (2015-06-18 04:19:48 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698