Issue 118416: Make the CheckLongLines() less restrictive in cases where it's hard to enforce.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118416: Make the CheckLongLines() less restrictive in cases where it's hard to enforce. (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make the CheckLongLines() less restrictive in cases where it's hard to enforce. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17937

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	presubmit_canned_checks.py	View		1 chunk	+10 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jói Sigurðsson

LGTM http://codereview.chromium.org/118416/diff/1/2 File presubmit_canned_checks.py (right): http://codereview.chromium.org/118416/diff/1/2#newcode104 Line 104: not 'http://' in line and a regexp ...

11 years, 6 months ago (2009-06-09 01:39:16 UTC) #2

M-A Ruel

11 years, 6 months ago (2009-06-09 01:44:37 UTC) #3

http://codereview.chromium.org/118416/diff/1/2
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/118416/diff/1/2#newcode104
Line 104: not 'http://' in line and
On 2009/06/09 01:39:16, Jói wrote:
> a regexp combining all of these cases would be faster - just one scan of the
> string; but this is most likely not performance sensitive code, so fine to
> ignore for now

Yes it's slightly verbose but I thought it was more readable this way than 2
regexp.

Expand Messages | Collapse Messages