Issue 1190913002: relnote: Remove IOVector from the write path in favor of a simpler

Issue 1190913002: relnote: Remove IOVector from the write path in favor of a simpler (Closed)

Created:
5 years, 6 months ago by ramant (doing other things)

Modified:
5 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett

Base URL:
https://chromium.googlesource.com/chromium/src.git@Added_new_flag_quic_send_fec_packet_95850278

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

relnote: Remove IOVector from the write path in favor of a simpler QuicIOVector struct. Estimated to save 2-3% of CPU. Merge internal change: 95926412 [email protected]

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+154 lines, -100 lines)			Patch
M	net/quic/quic_connection.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	4 chunks	+17 lines, -13 lines	0 comments	Download
M	net/quic/quic_headers_stream_test.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/quic/quic_packet_creator.h	View	2 chunks	+12 lines, -2 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	3 chunks	+27 lines, -6 lines	0 comments	Download
M	net/quic/quic_packet_creator_test.cc	View	17 chunks	+38 lines, -33 lines	0 comments	Download
M	net/quic/quic_packet_generator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_packet_generator.cc	View	5 chunks	+8 lines, -9 lines	0 comments	Download
M	net/quic/quic_packet_generator_test.cc	View	2 chunks	+9 lines, -4 lines	0 comments	Download
M	net/quic/quic_protocol.h	View	3 chunks	+14 lines, -2 lines	0 comments	Download
M	net/quic/quic_session.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_session.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/quic_session_test.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	net/quic/quic_utils.h	View	2 chunks	+8 lines, -5 lines	0 comments	Download
M	net/quic/reliable_quic_stream.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/quic_spdy_server_stream_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

Hi Ryan, Will delete IOVector class in a follow up CL. We only use TotalIovecLength ...

5 years, 6 months ago (2015-06-17 03:07:01 UTC) #2

chromium-reviews

5 years, 6 months ago (2015-06-17 14:02:28 UTC) #4

Sounds great, hopefully it won't return :-)
On Jun 16, 2015 8:07 PM, <[email protected]> wrote:

> Hi Ryan,
>  Will delete  IOVector class in a follow up CL. We only use
> TotalIovecLength
> method from iovector.h.
>
> thanks
> raman
>
> https://codereview.chromium.org/1190913002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].

Expand Messages | Collapse Messages