Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1210743002: Fix network quality estimator tests (Closed)

Created:
5 years, 6 months ago by tbansal1
Modified:
5 years, 6 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix network quality estimator tests (1) Enabling the tests that were disabled on Windows: Windows requires nested classes to have EXPORT macros. (2) Enabling the flaky test: Sometimes the RTT observation may be equal to base::TimeDelta() because of low timer granularity. This was causing one of the network quality estimator test to flake. BUG=504058, 492410 Committed: https://crrev.com/5659c35e1ee2d27bc4780a3908607645334fbb84 Cr-Commit-Position: refs/heads/master@{#336175}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M net/base/network_quality_estimator.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/network_quality_estimator_unittest.cc View 1 6 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tbansal1
ptal. thanks a lot for your time!!
5 years, 6 months ago (2015-06-25 01:36:14 UTC) #2
tbansal1
ptal. thanks a lot for your time!!
5 years, 6 months ago (2015-06-25 01:36:38 UTC) #3
pauljensen
lgtm
5 years, 6 months ago (2015-06-25 03:11:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210743002/20001
5 years, 6 months ago (2015-06-25 15:20:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-25 16:49:45 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 16:50:37 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5659c35e1ee2d27bc4780a3908607645334fbb84
Cr-Commit-Position: refs/heads/master@{#336175}

Powered by Google App Engine
This is Rietveld 408576698