gl/test: Move some initialization code used in tests to a separate component.

gl/test: Move some initialization code used in tests to a separate component.

Moving test-code to a separete component, so that adding more test-only
dependencies does not affect non-test code.

BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jam@ for non-ui/gl/ changes, since trivial #include/gyp-gn updates

Committed: https://crrev.com/ba162cdaf95c99b67da214be4cc8117db9ad2a5f
Cr-Commit-Position: refs/heads/master@{#339539}

[sadrul, 2015-07-19 08:43:17]

Patchset #5 (id:80001) has been deleted

[sadrul, 2015-07-19 15:51:05]

Patchset #4 (id:60001) has been deleted

[sadrul, 2015-07-19 15:51:14]

Patchset #3 (id:40001) has been deleted

[sadrul, 2015-07-19 15:51:22]

Patchset #2 (id:20001) has been deleted

[sadrul, 2015-07-19 15:51:32]

Patchset #1 (id:1) has been deleted

[sadrul, 2015-07-20 06:10:23]

[email protected] changed reviewers:
+ [email protected], [email protected]

[sadrul, 2015-07-20 06:10:24]

kbr@ and piman@ for ui/gl/ OWNERS. Does this look like a reasonable thing to do?
I have another CL (https://codereview.chromium.org/1228173003/) that adds some
dependencies to ui/gl for GLSurface::InitializeOneOffForTests(), and I thought
it'd be better to split this out into a separate component used by tests. WDYT?

[Ken Russell (switch to Gerrit), 2015-07-20 19:19:01]

[email protected] changed reviewers:
+ [email protected]

[Ken Russell (switch to Gerrit), 2015-07-20 19:19:01]

This refactoring seems reasonable. Good idea. LGTM as long as it compiles.

[no sievers, 2015-07-20 20:45:39]

lgtm w/nits

https://codereview.chromium.org/1238443004/diff/120001/gpu/BUILD.gn
File gpu/BUILD.gn (right):

https://codereview.chromium.org/1238443004/diff/120001/gpu/BUILD.gn#newcode120
gpu/BUILD.gn:120: "//ui/gl:test_support",
gl_tests actually uses real GL, see gl_tests_main.cc.

https://codereview.chromium.org/1238443004/diff/120001/ui/gl/test/gl_surface_...
File ui/gl/test/gl_surface_test_support.cc (right):

https://codereview.chromium.org/1238443004/diff/120001/ui/gl/test/gl_surface_...
ui/gl/test/gl_surface_test_support.cc:33: switches::kUseGpuInTests))
nit: indent; also use braces

https://codereview.chromium.org/1238443004/diff/120001/ui/gl/test/gl_surface_...
ui/gl/test/gl_surface_test_support.cc:74: fallback_to_osmesa,
nit: indent

https://codereview.chromium.org/1238443004/diff/120001/ui/gl/test/gl_surface_...
File ui/gl/test/gl_surface_test_support.h (right):

https://codereview.chromium.org/1238443004/diff/120001/ui/gl/test/gl_surface_...
ui/gl/test/gl_surface_test_support.h:12: class GLSurfaceTest {
nit: GLSurfaceTestSupport

[sadrul, 2015-07-20 21:21:48]

Patchset #3 (id:140001) has been deleted

[sadrul, 2015-07-20 21:36:31]

https://codereview.chromium.org/1238443004/diff/120001/gpu/BUILD.gn
File gpu/BUILD.gn (right):

https://codereview.chromium.org/1238443004/diff/120001/gpu/BUILD.gn#newcode120
gpu/BUILD.gn:120: "//ui/gl:test_support",
On 2015/07/20 20:45:39, sievers wrote:
> gl_tests actually uses real GL, see gl_tests_main.cc.

Done.

https://codereview.chromium.org/1238443004/diff/120001/ui/gl/test/gl_surface_...
File ui/gl/test/gl_surface_test_support.cc (right):

https://codereview.chromium.org/1238443004/diff/120001/ui/gl/test/gl_surface_...
ui/gl/test/gl_surface_test_support.cc:33: switches::kUseGpuInTests))
On 2015/07/20 20:45:39, sievers wrote:
> nit: indent; also use braces

Added braces. 'git cl format' seems to leave the indent as it is.

https://codereview.chromium.org/1238443004/diff/120001/ui/gl/test/gl_surface_...
ui/gl/test/gl_surface_test_support.cc:74: fallback_to_osmesa,
On 2015/07/20 20:45:39, sievers wrote:
> nit: indent

Done.

https://codereview.chromium.org/1238443004/diff/120001/ui/gl/test/gl_surface_...
File ui/gl/test/gl_surface_test_support.h (right):

https://codereview.chromium.org/1238443004/diff/120001/ui/gl/test/gl_surface_...
ui/gl/test/gl_surface_test_support.h:12: class GLSurfaceTest {
On 2015/07/20 20:45:39, sievers wrote:
> nit: GLSurfaceTestSupport

Done.

[sadrul, 2015-07-20 21:40:05]

[email protected] changed reviewers:
+ [email protected]

[sadrul, 2015-07-20 21:40:06]

+jam@ for toplevel owner stamp (will TBR since the relevant changes are only
#include and gyp/gn changes to depend on the new test-target from tests)

[sadrul, 2015-07-20 21:41:25]

The CQ bit was checked by [email protected]

[sadrul, 2015-07-20 21:41:26]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected]
Link to the patchset: https://codereview.chromium.org/1238443004/#ps160001
(title: ".")

[commit-bot: I haz the power, 2015-07-20 21:41:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1238443004/160001

[commit-bot: I haz the power, 2015-07-20 21:53:32]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2015-07-20 21:53:33]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2015-07-20 21:57:46]

lgtm

[sadrul, 2015-07-20 21:58:47]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2015-07-20 21:59:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1238443004/160001

[commit-bot: I haz the power, 2015-07-20 22:34:57]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2015-07-20 22:36:00]

Patchset 3 (id:??) landed as
https://crrev.com/ba162cdaf95c99b67da214be4cc8117db9ad2a5f
Cr-Commit-Position: refs/heads/master@{#339539}