Issue 1247563002: QUIC - reverted the debugging code to find crash in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1247563002: QUIC - reverted the debugging code to find crash in (Closed)

Created:
5 years, 5 months ago by ramant (doing other things)

Modified:
5 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

QUIC - reverted the debugging code to find crash in net::QuicPacket::FecProtectedData. The following CL handles QuicFramer::BuildDataPacket returning a nullptr. https://codereview.chromium.org/1246793002/ BUG=479880, 512446 [email protected] Committed: https://crrev.com/198829047080d1b272633914f1ec075771848a68 Cr-Commit-Position: refs/heads/master@{#339756}

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -22 lines)			Patch
	M	net/quic/quic_framer.cc	View		4 chunks	+11 lines, -22 lines	0 comments	Download

Dependent Patchsets:

Issue 1246093003 Patch 1

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247563002/1

5 years, 5 months ago (2015-07-21 21:50:59 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-21 21:59:36 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/198829047080d1b272633914f1ec075771848a68
Cr-Commit-Position: refs/heads/master@{#339756}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages