Improve the v8::Object uniqueness check in V8ValueConverterImpl

content/renderer/v8_value_converter_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_
 #define CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_
 
-#include <set>
+#include <map>
 
 #include "base/compiler_specific.h"
 #include "content/common/content_export.h"
 #include "content/public/renderer/v8_value_converter.h"
 
 namespace base {
 class BinaryValue;
 class DictionaryValue;
 class ListValue;
 class Value;
@@ skipping 11 matching lines @@
   virtual void SetFunctionAllowed(bool val) OVERRIDE;
   virtual void SetStripNullFromObjects(bool val) OVERRIDE;
   virtual v8::Handle<v8::Value> ToV8Value(
       const base::Value* value,
       v8::Handle<v8::Context> context) const OVERRIDE;
   virtual base::Value* FromV8Value(
       v8::Handle<v8::Value> value,
       v8::Handle<v8::Context> context) const OVERRIDE;
 
  private:
+  typedef std::multimap<int, v8::Handle<v8::Object> > HashToHandleMap;
+
   v8::Handle<v8::Value> ToV8ValueImpl(const base::Value* value) const;
   v8::Handle<v8::Value> ToV8Array(const base::ListValue* list) const;
   v8::Handle<v8::Value> ToV8Object(
       const base::DictionaryValue* dictionary) const;
   v8::Handle<v8::Value> ToArrayBuffer(const base::BinaryValue* value) const;
 
   base::Value* FromV8ValueImpl(v8::Handle<v8::Value> value,
-                               std::set<int>* unique_set) const;
+                               HashToHandleMap* unique_map) const;
   base::Value* FromV8Array(v8::Handle<v8::Array> array,
-                           std::set<int>* unique_set) const;
+                           HashToHandleMap* unique_map) const;
 
   // This will convert objects of type ArrayBuffer or any of the
   // ArrayBufferView subclasses. The return value will be NULL if |value| is
   // not one of these types.
   base::BinaryValue* FromV8Buffer(v8::Handle<v8::Value> value) const;
 
   base::Value* FromV8Object(v8::Handle<v8::Object> object,
-                            std::set<int>* unique_set) const;
+                            HashToHandleMap* unique_map) const;
+
+  // If |handle| is not in |map|, then adds it to |map| and returns true.

[eaugusti, 2013/03/14 17:21:09]

nit: "add" and "return" (singular).

[vabr (Chromium), 2013/03/14 17:59:37]

Done.

+  // Otherwise does nothing and returns false.
+  static bool UpdateAndCheckUniqueness(HashToHandleMap* map,
+                                       v8::Handle<v8::Object> handle);
 
   // If true, we will convert Date JavaScript objects to doubles.
   bool date_allowed_;
 
   // If true, we will convert RegExp JavaScript objects to string.
   bool reg_exp_allowed_;
 
   // If true, we will convert Function JavaScript objects to dictionaries.
   bool function_allowed_;
 
   // If true, undefined and null values are ignored when converting v8 objects
   // into Values.
   bool strip_null_from_objects_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_