cc: Chromify the LayerTreeHostImpl class.

cc: Chromify the LayerTreeHostImpl class.

Style-only change. Make the LayerTreeHostImpl and InputHandlerClient classes
follow chromium style.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187908

[enne (OOO), 2013-03-13 05:22:05]

lgtm

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc
File cc/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:217: // opportunity to create tilings.  Other paths
can call updateDrawProperties
UpdateDrawProperties

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:236: TRACE_EVENT_INSTANT0("cc",
"LayerTreeHostImpl::canDraw no root layer");
CanDraw

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:240: TRACE_EVENT_INSTANT0("cc",
"LayerTreeHostImpl::canDraw empty viewport");
CanDraw

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:245: "cc", "LayerTreeHostImpl::canDraw viewport size
recently changed");
CanDraw

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:249: TRACE_EVENT_INSTANT0("cc",
"LayerTreeHostImpl::canDraw no renderer");
CanDraw

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:254: "cc", "LayerTreeHostImpl::canDraw contents
textures purged");
CanDraw

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:452: float opacity = 1;
1.f

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:493: "LayerTreeHostImpl::calculateRenderPasses",
CalculateRenderPasses

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:659: if (!time_source_client_adapter_)
{}

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:801: TRACE_EVENT0("cc",
"LayerTreeHostImpl::prepareToDraw");
PrepareToDraw

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:933: TRACE_EVENT0("cc",
"LayerTreeHostImpl::drawLayers");
DrawLayers

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:1508: } else
{}

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:1538: gfx::Vector2dF
perpendicularAxis(-applied_delta.y(), applied_delta.x());
perpendicular_axis

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:1572: TRACE_EVENT0("cc",
"LayerTreeHostImpl::pinchGestureUpdate");
PinchGestureUpdate

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:1685: TRACE_EVENT0("cc",
"LayerTreeHostImpl::animateLayers");
AnimateLayers

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:1709: TRACE_EVENT0("cc",
"LayerTreeHostImpl::updateAnimationState");
UpdateAnimationState

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:1795: size_t memoryUseBytes) {
memory_use_bytes

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.h
File cc/layer_tree_host_impl.h (right):

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.h#new...
cc/layer_tree_host_impl.h:211: size_t MemoryAllocationLimitBytes() const {
return managed_memory_policy_.bytesLimitWhenVisible; }
80 col.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.h#new...
cc/layer_tree_host_impl.h:213: void SetViewportSize(gfx::Size
layout_viewport_size, gfx::Size device_viewport_size);
80 col.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.h#new...
cc/layer_tree_host_impl.h:227: bool needs_animate_layers() const { return
!animation_registrar_->active_animation_controllers().empty(); }
80 col.

[danakj, 2013-03-13 15:49:11]

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc
File cc/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:217: // opportunity to create tilings.  Other paths
can call updateDrawProperties
On 2013/03/13 05:22:05, enne wrote:
> UpdateDrawProperties

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:236: TRACE_EVENT_INSTANT0("cc",
"LayerTreeHostImpl::canDraw no root layer");
On 2013/03/13 05:22:05, enne wrote:
> CanDraw

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:240: TRACE_EVENT_INSTANT0("cc",
"LayerTreeHostImpl::canDraw empty viewport");
On 2013/03/13 05:22:05, enne wrote:
> CanDraw

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:245: "cc", "LayerTreeHostImpl::canDraw viewport size
recently changed");
On 2013/03/13 05:22:05, enne wrote:
> CanDraw

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:249: TRACE_EVENT_INSTANT0("cc",
"LayerTreeHostImpl::canDraw no renderer");
On 2013/03/13 05:22:05, enne wrote:
> CanDraw

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:254: "cc", "LayerTreeHostImpl::canDraw contents
textures purged");
On 2013/03/13 05:22:05, enne wrote:
> CanDraw

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:452: float opacity = 1;
On 2013/03/13 05:22:05, enne wrote:
> 1.f

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:493: "LayerTreeHostImpl::calculateRenderPasses",
On 2013/03/13 05:22:05, enne wrote:
> CalculateRenderPasses

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:659: if (!time_source_client_adapter_)
On 2013/03/13 05:22:05, enne wrote:
> {}

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:801: TRACE_EVENT0("cc",
"LayerTreeHostImpl::prepareToDraw");
On 2013/03/13 05:22:05, enne wrote:
> PrepareToDraw

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:933: TRACE_EVENT0("cc",
"LayerTreeHostImpl::drawLayers");
On 2013/03/13 05:22:05, enne wrote:
> DrawLayers

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:1508: } else
On 2013/03/13 05:22:05, enne wrote:
> {}

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:1538: gfx::Vector2dF
perpendicularAxis(-applied_delta.y(), applied_delta.x());
On 2013/03/13 05:22:05, enne wrote:
> perpendicular_axis

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:1572: TRACE_EVENT0("cc",
"LayerTreeHostImpl::pinchGestureUpdate");
On 2013/03/13 05:22:05, enne wrote:
> PinchGestureUpdate

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:1685: TRACE_EVENT0("cc",
"LayerTreeHostImpl::animateLayers");
On 2013/03/13 05:22:05, enne wrote:
> AnimateLayers

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:1709: TRACE_EVENT0("cc",
"LayerTreeHostImpl::updateAnimationState");
On 2013/03/13 05:22:05, enne wrote:
> UpdateAnimationState

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:1795: size_t memoryUseBytes) {
On 2013/03/13 05:22:05, enne wrote:
> memory_use_bytes

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.h
File cc/layer_tree_host_impl.h (right):

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.h#new...
cc/layer_tree_host_impl.h:211: size_t MemoryAllocationLimitBytes() const {
return managed_memory_policy_.bytesLimitWhenVisible; }
On 2013/03/13 05:22:05, enne wrote:
> 80 col.

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.h#new...
cc/layer_tree_host_impl.h:213: void SetViewportSize(gfx::Size
layout_viewport_size, gfx::Size device_viewport_size);
On 2013/03/13 05:22:05, enne wrote:
> 80 col.

Done.

https://codereview.chromium.org/12648005/diff/1/cc/layer_tree_host_impl.h#new...
cc/layer_tree_host_impl.h:227: bool needs_animate_layers() const { return
!animation_registrar_->active_animation_controllers().empty(); }
On 2013/03/13 05:22:05, enne wrote:
> 80 col.

Done.

[commit-bot: I haz the power, 2013-03-13 19:00:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12648005/12001

[danakj, 2013-03-13 19:06:35]

Committed patchset #3 manually as r187908 (presubmit successful).