Make WebContentsDelegate::OpenColorChooser return NULL on failure

Make WebContentsDelegate::OpenColorChooser return NULL on failure

Changing WebContentsDelegate::OpenColorChooser to return NULL on failure so we don't put the same ColorChooser into two scoped_ptrs(WebContentsImpl::color_chooser_)

BUG=331790
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244710

[keishi, 2014-01-08 12:01:55]

I can't reproduce the crash but what I think is happening is:
Tab B tries to open a color chooser after tab A opens a color chooser.
WebContentsDelegate::OpenColorChooser returns the ColorChooser instance for tab
A to tab B, causing the same ColorChooser instance to be stored in two
scoped_ptrs (WebContentsImpl::color_chooser_ for tabs A and B).

pkasting@ could you look at color_chooser_win.cc.
jam@ could you look at web_contents_delegate.h and web_contents_impl.cc.

Thanks!

[jam, 2014-01-09 02:14:07]

On 2014/01/08 12:01:55, keishi1 wrote:
> I can't reproduce the crash but what I think is happening is:
> Tab B tries to open a color chooser after tab A opens a color chooser.
> WebContentsDelegate::OpenColorChooser returns the ColorChooser instance for
tab
> A to tab B, causing the same ColorChooser instance to be stored in two
> scoped_ptrs (WebContentsImpl::color_chooser_ for tabs A and B).
> 
> pkasting@ could you look at color_chooser_win.cc.
> jam@ could you look at web_contents_delegate.h and web_contents_impl.cc.
> 
> Thanks!

lgtm

[Peter Kasting, 2014-01-14 01:10:01]

So the color chooser is app-modal, and thus there's no way to have more than one
open at once, or close the already-open one?

If so, LGTM

[keishi, 2014-01-14 01:58:30]

On 2014/01/14 01:10:01, Peter Kasting wrote:
> So the color chooser is app-modal, and thus there's no way to have more than
one
> open at once, or close the already-open one?
Yes.
> If so, LGTM

Thanks.

[commit-bot: I haz the power, 2014-01-14 02:29:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/128053002/1

[commit-bot: I haz the power, 2014-01-14 14:56:31]

Change committed as 244710