Popular sites on the NTP: Allow blacklisting

Popular sites on the NTP: Allow blacklisting

This re-uses the existing TopSites blacklist, which is now updated even when the SuggestionsService is active.

BUG=516618
Committed: https://crrev.com/fac751947c656d2322c34b8186dbd9dfdce30af2
Cr-Commit-Position: refs/heads/master@{#343672}

[Marc Treib, 2015-08-12 12:28:07]

[email protected] changed reviewers:
+ [email protected]

[Marc Treib, 2015-08-12 12:28:08]

And another one! PTAL!

https://codereview.chromium.org/1290723002/diff/1/chrome/browser/android/most...
File chrome/browser/android/most_visited_sites.cc (right):

https://codereview.chromium.org/1290723002/diff/1/chrome/browser/android/most...
chrome/browser/android/most_visited_sites.cc:267: // Always blacklist in the
local TopSites.
This changes existing behavior: The TopSites blacklist is now always updated,
even when we're using the SuggestionsService. I think that's actually
preferable: If I've blacklisted site.com (while using the SuggestionsService),
then I don't want to see it even when I get the TopSites fallback for some
reason.
If you agree, then I should probably add someone from the NTP team to confirm.

[I guess the alternative would be to introduce a *third* blacklist just for the
popular sites, but I'd really like to avoid that.. two is already one too many.]

[Bernhard Bauer, 2015-08-12 14:45:41]

lgtm

https://codereview.chromium.org/1290723002/diff/1/chrome/browser/android/most...
File chrome/browser/android/most_visited_sites.cc (right):

https://codereview.chromium.org/1290723002/diff/1/chrome/browser/android/most...
chrome/browser/android/most_visited_sites.cc:267: // Always blacklist in the
local TopSites.
On 2015/08/12 12:28:07, Marc Treib wrote:
> This changes existing behavior: The TopSites blacklist is now always updated,
> even when we're using the SuggestionsService. I think that's actually
> preferable: If I've blacklisted http://site.com (while using the
SuggestionsService),
> then I don't want to see it even when I get the TopSites fallback for some
> reason.
> If you agree, then I should probably add someone from the NTP team to confirm.
> 
> [I guess the alternative would be to introduce a *third* blacklist just for
the
> popular sites, but I'd really like to avoid that.. two is already one too
many.]

Yeah, I agree.

[Marc Treib, 2015-08-12 16:08:37]

[email protected] changed reviewers:
+ [email protected]

[Marc Treib, 2015-08-12 16:08:37]

+mathp who seems to be the main author of this file.
This CL slightly changes how NTP blacklisting is done: Always also blacklist in
TopSites, even when the SuggestionsService is active. Rationale: If I've
blacklisted site.com (while using the SuggestionsService), then I don't want to
see it even when I get the TopSites fallback for some reason.
Please check if you see any problems with this. Thanks!

[Mathieu, 2015-08-12 16:27:12]

[email protected] changed reviewers:
+ [email protected]

[Marc Treib, 2015-08-17 09:07:25]

On 2015/08/12 16:08:37, Marc Treib wrote:
> +mathp who seems to be the main author of this file.
> This CL slightly changes how NTP blacklisting is done: Always also blacklist
in
> TopSites, even when the SuggestionsService is active. Rationale: If I've
> blacklisted http://site.com (while using the SuggestionsService), then I don't
want to
> see it even when I get the TopSites fallback for some reason.
> Please check if you see any problems with this. Thanks!

Ping: mathp or fserb, any concerns here?

[Mathieu, 2015-08-17 12:28:26]

Not concerned, no. lgtm

However, if the SuggestionsService is active, make sure you check that there are
no observers that replace the NTP data when BlacklistUrl is called on TopSites.
I don't think it happens, but it's easy to check: blacklisting a
SuggestionsService tile will replace all tiles with TopSites tiles.

[Marc Treib, 2015-08-17 12:38:00]

On 2015/08/17 12:28:26, Mathieu Perreault wrote:
> Not concerned, no. lgtm
> 
> However, if the SuggestionsService is active, make sure you check that there
are
> no observers that replace the NTP data when BlacklistUrl is called on
TopSites.
> I don't think it happens, but it's easy to check: blacklisting a
> SuggestionsService tile will replace all tiles with TopSites tiles.

We will get called back via TopSitesChanged, but that only does anything when
mv_source_ is TOP_SITES. So we're all good here :)

[Marc Treib, 2015-08-17 12:38:13]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2015-08-17 12:38:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1290723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1290723002/1

[commit-bot: I haz the power, 2015-08-17 13:21:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-17 13:22:02]

Patchset 1 (id:??) landed as
https://crrev.com/fac751947c656d2322c34b8186dbd9dfdce30af2
Cr-Commit-Position: refs/heads/master@{#343672}