cc: Add --ui-foo flags for all compositor debug visualizations.

cc: Add --ui-foo flags for all compositor debug visualizations.

For every --show-debug-thing flag, we should have a mirrored
--ui-show-debug-thing flag to show the same information in the
UI compositor.

Move the current ui-compositor flags to cc/base/switches.h where the
renderer-compositor flags are, so that the mirrored nature is easily
seen and maintained. Also move the few renderer-compositor flags for
these compositor features to cc/base/switches.h.

The only flag that can't move is kShowPaintRects, as it is also used
for the software non-compositing path. So instead we mirror this flag
in the ui-compositor switches.

R=piman

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189062

[danakj, 2013-03-18 23:20:02]

https://codereview.chromium.org/12909003/diff/1/cc/base/switches.cc
File cc/base/switches.cc (right):

https://codereview.chromium.org/12909003/diff/1/cc/base/switches.cc#newcode84
cc/base/switches.cc:84: const char kUIShowCompositedLayerBorders[] =
"ui-show-layer-borders";
This and ui-show-layer-tree aren't exact ui- mirrors, but i left them as their
current values.

[danakj, 2013-03-18 23:29:39]

https://codereview.chromium.org/12909003/diff/1/ui/compositor/compositor.cc
File ui/compositor/compositor.cc (left):

https://codereview.chromium.org/12909003/diff/1/ui/compositor/compositor.cc#o...
ui/compositor/compositor.cc:427: settings.partialSwapEnabled =
oh this should only replace the initialDebugState values, not the other settings
values. will fix.

[danakj, 2013-03-18 23:34:14]

https://codereview.chromium.org/12909003/diff/1/ui/compositor/compositor.cc
File ui/compositor/compositor.cc (left):

https://codereview.chromium.org/12909003/diff/1/ui/compositor/compositor.cc#o...
ui/compositor/compositor.cc:427: settings.partialSwapEnabled =
On 2013/03/18 23:29:39, danakj wrote:
> oh this should only replace the initialDebugState values, not the other
settings
> values. will fix.

Done.

[piman, 2013-03-18 23:43:49]

Really 6 vs half a dozen. To me it feels like a layering violation (just like
the renderer flags are too), but other strong heads disagree.

If you think it improves consistency, why not.

https://codereview.chromium.org/12909003/diff/6001/ui/compositor/compositor_s...
File ui/compositor/compositor_switches.cc (right):

https://codereview.chromium.org/12909003/diff/6001/ui/compositor/compositor_s...
ui/compositor/compositor_switches.cc:11: const char kUIEnablePartialSwap[] =
"ui-enable-partial-swap";
What about this one?

https://codereview.chromium.org/12909003/diff/6001/ui/compositor/compositor_s...
ui/compositor/compositor_switches.cc:15: const char kUIEnablePerTilePainting[] =
"ui-enable-per-tile-painting";
And this one?

https://codereview.chromium.org/12909003/diff/6001/ui/compositor/compositor_s...
ui/compositor/compositor_switches.cc:17: const char
kUIEnableThreadedCompositing[] = "ui-enable-threaded-compositing";
And maybe this one?

[danakj, 2013-03-18 23:46:08]

https://codereview.chromium.org/12909003/diff/6001/ui/compositor/compositor_s...
File ui/compositor/compositor_switches.cc (right):

https://codereview.chromium.org/12909003/diff/6001/ui/compositor/compositor_s...
ui/compositor/compositor_switches.cc:11: const char kUIEnablePartialSwap[] =
"ui-enable-partial-swap";
On 2013/03/18 23:43:49, piman wrote:
> What about this one?

Sure, these aren't debug flags, but I don't mind moving everything that has a
renderer/ui mirror.

[danakj, 2013-03-19 01:55:56]

I also copied all the compositor flags (other than android-specific top controls
ones) to chrome/browser/chromeos/login/chrome_restart_request.cc while I'm
there, so that the guest mode compositor behaves the same as the non-guest mode
one.

https://codereview.chromium.org/12909003/diff/6001/ui/compositor/compositor_s...
File ui/compositor/compositor_switches.cc (right):

https://codereview.chromium.org/12909003/diff/6001/ui/compositor/compositor_s...
ui/compositor/compositor_switches.cc:17: const char
kUIEnableThreadedCompositing[] = "ui-enable-threaded-compositing";
On 2013/03/18 23:43:49, piman wrote:
> And maybe this one?

This one doesn't correspond to a cc::LayerTreeSettings value - ie it's never
actually used in CC, just in the embedder. So maybe I'll leave it here.

[piman, 2013-03-19 02:13:19]

lgtm

[danakj, 2013-03-19 02:24:25]

+sky for chrome/ OWNERS

[sky, 2013-03-19 14:27:43]

LGTM

https://codereview.chromium.org/12909003/diff/17002/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/chrome_restart_request.cc (right):

https://codereview.chromium.org/12909003/diff/17002/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/chrome_restart_request.cc:93:
::switches::kDisableThreadedCompositing,
Would be nice if we try to keep these sorted.

https://codereview.chromium.org/12909003/diff/17002/ui/compositor/compositor_...
File ui/compositor/compositor_switches.h (right):

https://codereview.chromium.org/12909003/diff/17002/ui/compositor/compositor_...
ui/compositor/compositor_switches.h:13: COMPOSITOR_EXPORT extern const char
kUIShowPaintRects[];
Same comment about sorting.

[danakj, 2013-03-19 15:42:09]

https://codereview.chromium.org/12909003/diff/17002/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/chrome_restart_request.cc (right):

https://codereview.chromium.org/12909003/diff/17002/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/chrome_restart_request.cc:93:
::switches::kDisableThreadedCompositing,
On 2013/03/19 14:27:43, sky wrote:
> Would be nice if we try to keep these sorted.

Done.

https://codereview.chromium.org/12909003/diff/17002/ui/compositor/compositor_...
File ui/compositor/compositor_switches.h (right):

https://codereview.chromium.org/12909003/diff/17002/ui/compositor/compositor_...
ui/compositor/compositor_switches.h:13: COMPOSITOR_EXPORT extern const char
kUIShowPaintRects[];
On 2013/03/19 14:27:43, sky wrote:
> Same comment about sorting.

Done.

[commit-bot: I haz the power, 2013-03-19 17:28:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/12909003/34001

[danakj, 2013-03-19 18:47:03]

Committed patchset #4 manually as r189062 (presubmit successful).