Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132093008: Remove some unnecessary includes from extension_function_dispatcher.cc (Closed)

Created:
6 years, 10 months ago by James Cook
Modified:
6 years, 10 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Remove some unnecessary includes from extension_function_dispatcher.cc This is a small step toward breaking ExtensionFunctionDispatcher's src/chrome dependencies so it can move to src/extensions. BUG=332986 TEST=compiles [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/extensions/extension_function_dispatcher.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
James Cook
The CQ bit was checked by [email protected]
6 years, 10 months ago (2014-02-07 18:52:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/132093008/1
6 years, 10 months ago (2014-02-07 18:56:09 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by [email protected]
6 years, 10 months ago (2014-02-07 20:51:20 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=260032
6 years, 10 months ago (2014-02-07 20:51:20 UTC) #4
James Cook
The CQ bit was checked by [email protected]
6 years, 10 months ago (2014-02-07 20:57:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/132093008/1
6 years, 10 months ago (2014-02-07 21:00:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/132093008/1
6 years, 10 months ago (2014-02-07 22:22:05 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 23:00:26 UTC) #8
Message was sent while issue was closed. 
Change committed as 249836

Powered by Google App Engine
This is Rietveld 408576698