Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 133273028: Cleanup: Move a couple argument DeepCopy() calls closer to their use site in ExtensionFunctionDispa… (Closed)

Created:
6 years, 11 months ago by Lei Zhang
Modified:
6 years, 11 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Cleanup: Move a couple argument DeepCopy() calls closer to their use site in ExtensionFunctionDispatcher. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/extensions/extension_function_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 4 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
Why make a copy if you may not even it?
6 years, 11 months ago (2014-01-17 03:31:43 UTC) #1
Lei Zhang
ping
6 years, 11 months ago (2014-01-21 19:53:29 UTC) #2
Yoyo Zhou
LGTM
6 years, 11 months ago (2014-01-21 22:15:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/133273028/1
6 years, 11 months ago (2014-01-21 22:21:00 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=249332
6 years, 11 months ago (2014-01-22 00:52:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/133273028/1
6 years, 11 months ago (2014-01-22 01:03:30 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 01:49:02 UTC) #7
Message was sent while issue was closed.
Change committed as 246202

Powered by Google App Engine
This is Rietveld 408576698