Refactor FileSystem

content/renderer/pepper/null_file_system_callback_dispatcher.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_PEPPER_NULL_FILE_SYSTEM_CALLBACK_DISPATCHER_H_
+#define CONTENT_RENDERER_PEPPER_NULL_FILE_SYSTEM_CALLBACK_DISPATCHER_H_
+
+#include <vector>
+
+#include "base/basictypes.h"
+#include "base/files/file_path.h"
+#include "base/files/file_util_proxy.h"
+#include "base/logging.h"
+#include "base/platform_file.h"
+#include "content/common/fileapi/file_system_dispatcher.h"
+#include "googleurl/src/gurl.h"
+#include "ppapi/shared_impl/file_type_conversion.h"
+#include "webkit/fileapi/file_system_callback_dispatcher.h"
+
+namespace content {
+
+class NullFileSystemCallbackDispatcher
+    : public fileapi::FileSystemCallbackDispatcher {

[yzshen1, 2013/04/08 21:05:16]

I wonder why fileapi::FileSystemCallbackDispatcher has to declare pure virtual
methods.
Maybe we could ask the owner to see whether it makes sense to merge this class
into  fileapi::FileSystemCallbackDispatcher? (Except the Ppapi-specific
DidFail() method.)

[victorhsieh, 2013/04/09 18:02:45]

As discussed offline, we'll keep this as it is (and should be refactored
together with fileapi side).

+ public:
+  NullFileSystemCallbackDispatcher() {}
+
+  virtual ~NullFileSystemCallbackDispatcher() {}
+
+  virtual void DidSucceed() OVERRIDE {
+    NOTREACHED();
+  }
+
+  virtual void DidReadMetadata(const base::PlatformFileInfo& file_info,
+                               const base::FilePath& platform_path) OVERRIDE {
+    NOTREACHED();
+  }
+
+  virtual void DidCreateSnapshotFile(
+      const base::PlatformFileInfo& file_info,
+      const base::FilePath& platform_path) OVERRIDE {
+    NOTREACHED();
+  }
+
+  virtual void DidReadDirectory(
+      const std::vector<base::FileUtilProxy::Entry>& entries,
+      bool has_more) OVERRIDE {
+    NOTREACHED();
+  }
+
+  virtual void DidOpenFileSystem(const std::string& name,
+                                 const GURL& root) OVERRIDE {
+    NOTREACHED();
+  }
+
+  virtual void DidWrite(int64 bytes, bool complete) OVERRIDE {
+    NOTREACHED();
+  }
+
+  virtual void DidOpenFile(base::PlatformFile file) OVERRIDE {
+    NOTREACHED();
+  }
+
+  virtual void DidFail(int pp_error) {

[yzshen1, 2013/04/08 21:05:16]

- Please use a different name instead of overloading.
- Please use int32_t for error values.

[victorhsieh, 2013/04/08 23:44:38]

Done.

+    NOTREACHED();
+  }
+
+ private:
+  virtual void DidFail(base::PlatformFileError platform_error) OVERRIDE {
+    DidFail(ppapi::PlatformFileErrorToPepperError(platform_error));
+  }
+
+  DISALLOW_COPY_AND_ASSIGN(NullFileSystemCallbackDispatcher);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_RENDERER_PEPPER_NULL_FILE_SYSTEM_CALLBACK_DISPATCHER_H_