Refactor FileSystem

content/renderer/pepper/pepper_plugin_delegate_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_plugin_delegate_impl.h"
 
 #include <cmath>
 #include <cstddef>
 #include <map>
 #include <queue>
@@ skipping 25 matching lines @@
 #include "content/public/common/referrer.h"
 #include "content/public/renderer/content_renderer_client.h"
 #include "content/public/renderer/renderer_restrict_dispatch_group.h"
 #include "content/renderer/gamepad_shared_memory_reader.h"
 #include "content/renderer/media/media_stream_dispatcher.h"
 #include "content/renderer/media/pepper_platform_video_decoder_impl.h"
 #include "content/renderer/p2p/socket_dispatcher.h"
 #include "content/renderer/pepper/content_renderer_pepper_host_factory.h"
 #include "content/renderer/pepper/pepper_broker_impl.h"
 #include "content/renderer/pepper/pepper_device_enumeration_event_handler.h"
+#include "content/renderer/pepper/pepper_file_system_host.h"
 #include "content/renderer/pepper/pepper_hung_plugin_filter.h"
 #include "content/renderer/pepper/pepper_in_process_resource_creation.h"
 #include "content/renderer/pepper/pepper_platform_audio_input_impl.h"
 #include "content/renderer/pepper/pepper_platform_audio_output_impl.h"
 #include "content/renderer/pepper/pepper_platform_context_3d_impl.h"
 #include "content/renderer/pepper/pepper_platform_image_2d_impl.h"
 #include "content/renderer/pepper/pepper_platform_video_capture_impl.h"
 #include "content/renderer/pepper/pepper_proxy_channel_delegate_impl.h"
 #include "content/renderer/pepper/renderer_ppapi_host_impl.h"
 #include "content/renderer/render_thread_impl.h"
@@ skipping 277 matching lines @@
 
   ppapi::PpapiPermissions perms(
       PepperPluginRegistry::GetInstance()->GetInfoForPlugin(
           webplugin_info)->permissions);
   RendererPpapiHostImpl* host_impl =
       RendererPpapiHostImpl::CreateOnModuleForInProcess(
           module, perms);
   render_view->PpapiPluginCreated(host_impl);
 }
 
+template <typename HostT>

[yzshen1, 2013/04/08 21:05:16]

nit: It seems better to use full name HostType.

[victorhsieh, 2013/04/08 23:44:38]

Done.

+const HostT* GetRendererResourceHost(
+    PP_Instance instance, PP_Resource resource) {
+  const ppapi::host::PpapiHost* ppapi_host =
+      RendererPpapiHost::GetForPPInstance(instance)->GetPpapiHost();
+  if (!resource|| !ppapi_host)

[yzshen1, 2013/04/08 21:05:16]

Missing space before ||.

[victorhsieh, 2013/04/08 23:44:38]

Done.

+    return NULL;
+  return static_cast<HostT*>(ppapi_host->GetResourceHost(resource));
+}
+
 }  // namespace
 
 PepperPluginDelegateImpl::PepperPluginDelegateImpl(RenderViewImpl* render_view)
     : RenderViewObserver(render_view),
       render_view_(render_view),
       focused_plugin_(NULL),
       last_mouse_event_target_(NULL),
       device_enumeration_event_handler_(
           new PepperDeviceEnumerationEventHandler()) {
 }
@@ skipping 656 matching lines @@
   // This method is called for every mouse event that the render view receives.
   // And then the mouse event is forwarded to WebKit, which dispatches it to the
   // event target. Potentially a Pepper plugin will receive the event.
   // In order to tell whether a plugin gets the last mouse event and which it
   // is, we set |last_mouse_event_target_| to NULL here. If a plugin gets the
   // event, it will notify us via DidReceiveMouseEvent() and set itself as
   // |last_mouse_event_target_|.
   last_mouse_event_target_ = NULL;
 }
 
-bool PepperPluginDelegateImpl::OpenFileSystem(
-    const GURL& origin_url,
-    fileapi::FileSystemType type,
-    long long size,
-    fileapi::FileSystemCallbackDispatcher* dispatcher) {
-  FileSystemDispatcher* file_system_dispatcher =
-      ChildThread::current()->file_system_dispatcher();
-  return file_system_dispatcher->OpenFileSystem(
-      origin_url, type, size, true /* create */, dispatcher);
+bool PepperPluginDelegateImpl::IsFileSystemOpened(PP_Instance instance,
+                                                  PP_Resource resource) const {
+  const PepperFileSystemHost* host =
+      GetRendererResourceHost<PepperFileSystemHost>(instance, resource);
+  return host && host->IsOpened();
+}
+
+PP_FileSystemType PepperPluginDelegateImpl::GetFileSystemType(
+    PP_Instance instance, PP_Resource resource) const {
+  const PepperFileSystemHost* host =
+      GetRendererResourceHost<PepperFileSystemHost>(instance, resource);
+  return host ? host->GetType() : PP_FILESYSTEMTYPE_INVALID;
+}
+
+std::string PepperPluginDelegateImpl::GetFileSystemRootUrl(
+    PP_Instance instance, PP_Resource resource) const {
+  const PepperFileSystemHost* host =
+      GetRendererResourceHost<PepperFileSystemHost>(instance, resource);
+  return host ? host->GetRootUrl() : "";

[yzshen1, 2013/04/08 21:05:16]

nit: please use std::string() instead of "".

[victorhsieh, 2013/04/08 23:44:38]

Done.

 }
 
 bool PepperPluginDelegateImpl::MakeDirectory(
     const GURL& path,
     bool recursive,
     fileapi::FileSystemCallbackDispatcher* dispatcher) {
   FileSystemDispatcher* file_system_dispatcher =
       ChildThread::current()->file_system_dispatcher();
   return file_system_dispatcher->Create(
       path, false, true, recursive, dispatcher);
@@ skipping 575 matching lines @@
     base::PlatformFile handle,
     base::ProcessId target_process_id,
     bool should_close_source) const {
   return BrokerGetFileHandleForProcess(
       handle,
       target_process_id,
       should_close_source);
 }
 
 }  // namespace content