Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 137923003: Change fileapi namespace to content for files that are moved under content/ (Closed)

Created:
6 years, 11 months ago by kinuko
Modified:
6 years, 11 months ago
Reviewers:
jam, mmenke, tzik
CC:
chromium-reviews, vandebo (ex-Chrome), cbentzel+watch_chromium.org, jam, nkostylev+watch_chromium.org, tzik, Lei Zhang, tfarina, Greg Billock, nhiroki, joi+watch-content_chromium.org, tommycli, darin-cc_chromium.org, dcheng, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Change fileapi namespace to content for test files that are moved under content/ Note that this temporarily adds some content:: notion in webkit/ (mostly for friend'ing / forward decls) This also includes some refactoring in some test code (namely obfuscated_file_util_unittest.cc) to work around cross-namespace friend'ing. BUG=265769 TEST=build TBR=mmenke Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245232

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : build fix #

Patch Set 4 : fixed stupid refactoring error #

Patch Set 5 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+735 lines, -548 lines) Patch
M chrome/browser/chromeos/drive/file_system_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/iphoto_file_util_unittest.cc View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc View 1 2 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/blob_url_request_job_unittest.cc View 3 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/fileapi/browser_file_system_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/copy_or_move_file_validator_unittest.cc View 7 chunks +17 lines, -11 lines 0 comments Download
M content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 28 chunks +68 lines, -58 lines 0 comments Download
M content/browser/fileapi/dragged_file_util_unittest.cc View 19 chunks +43 lines, -30 lines 0 comments Download
M content/browser/fileapi/file_system_context_unittest.cc View 12 chunks +42 lines, -32 lines 0 comments Download
M content/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 5 chunks +10 lines, -6 lines 0 comments Download
M content/browser/fileapi/file_system_file_stream_reader_unittest.cc View 6 chunks +13 lines, -7 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 7 chunks +16 lines, -10 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_write_unittest.cc View 6 chunks +13 lines, -9 lines 0 comments Download
M content/browser/fileapi/file_system_operation_runner_unittest.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_system_quota_client_unittest.cc View 9 chunks +25 lines, -14 lines 0 comments Download
M content/browser/fileapi/file_system_url_request_job_unittest.cc View 6 chunks +12 lines, -7 lines 0 comments Download
M content/browser/fileapi/file_writer_delegate_unittest.cc View 4 chunks +16 lines, -10 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/local_file_util_unittest.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M content/browser/fileapi/obfuscated_file_util_unittest.cc View 1 2 3 17 chunks +162 lines, -130 lines 0 comments Download
M content/browser/fileapi/plugin_private_file_system_backend_unittest.cc View 8 chunks +19 lines, -11 lines 0 comments Download
M content/browser/fileapi/recursive_operation_delegate_unittest.cc View 5 chunks +11 lines, -6 lines 0 comments Download
M content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc View 3 chunks +27 lines, -20 lines 0 comments Download
M content/browser/fileapi/sandbox_file_system_backend_unittest.cc View 16 chunks +24 lines, -21 lines 0 comments Download
M content/browser/fileapi/transient_file_util_unittest.cc View 5 chunks +16 lines, -11 lines 0 comments Download
M content/browser/fileapi/upload_file_system_file_element_reader_unittest.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M content/public/test/sandbox_file_system_test_helper.h View 4 chunks +19 lines, -17 lines 0 comments Download
M content/public/test/sandbox_file_system_test_helper.cc View 5 chunks +12 lines, -6 lines 0 comments Download
M content/public/test/test_file_system_backend.h View 3 chunks +29 lines, -24 lines 0 comments Download
M content/public/test/test_file_system_backend.cc View 9 chunks +34 lines, -26 lines 0 comments Download
M content/public/test/test_file_system_context.h View 1 chunk +9 lines, -6 lines 0 comments Download
M content/public/test/test_file_system_context.cc View 3 chunks +13 lines, -12 lines 0 comments Download
M content/public/test/test_file_system_options.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/public/test/test_file_system_options.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/url_request/url_request.h View 2 chunks +6 lines, -16 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_file_stream_reader.h View 2 chunks +5 lines, -1 line 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.h View 2 chunks +5 lines, -10 lines 0 comments Download
M webkit/browser/fileapi/plugin_private_file_system_backend.h View 2 chunks +5 lines, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend_delegate.h View 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
kinuko
As promised; fixing content namespace. PTL: jam@: content/ (and stamp for chrome/) tzik@: webkit/browser/fileapi
6 years, 11 months ago (2014-01-14 08:18:30 UTC) #1
tzik
lgtm
6 years, 11 months ago (2014-01-14 08:31:46 UTC) #2
jam
lgtm
6 years, 11 months ago (2014-01-14 16:58:53 UTC) #3
kinuko
TBR-ing mmenke@ for net/ (namespace change only for an existing class)
6 years, 11 months ago (2014-01-15 06:56:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/137923003/380001
6 years, 11 months ago (2014-01-15 08:27:17 UTC) #5
mmenke
On 2014/01/15 08:27:17, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 11 months ago (2014-01-15 15:30:12 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) app_list_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 11 months ago (2014-01-15 16:44:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/137923003/670001
6 years, 11 months ago (2014-01-15 16:45:39 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=214358
6 years, 11 months ago (2014-01-15 18:47:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/137923003/900001
6 years, 11 months ago (2014-01-16 05:27:33 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=212449
6 years, 11 months ago (2014-01-16 05:57:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/137923003/1080002
6 years, 11 months ago (2014-01-16 06:57:41 UTC) #12
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 17:35:57 UTC) #13
Message was sent while issue was closed.
Change committed as 245232

Powered by Google App Engine
This is Rietveld 408576698