Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
13954011:
Enable VariationsService on Android. (Closed)
|
Created:
7 years, 8 months ago by Alexei Svitkine (slow) Modified:
7 years, 8 months ago CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things), Yusuf, sky Base URL:
svn://svn.chromium.org/chrome/trunk/src/ Visibility:
Public. |
DescriptionEnable VariationsService on Android.
BUG=224018, 168224
TEST=On a Chrome for Android official build, launch Chrome, quit it and launch it again. Go to chrome://version and verify that the string "5a3c10b5" appears in the Variations list. (This corresponds to the server-controlled Test0PercentDefault field trial).
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195407
Patch Set 1 #
Total comments: 4
Messages
Total messages: 24 (0 generated)
A question for you. This mostly looks good - it seems to follow what I was doing when I was enabling this to test. https://codereview.chromium.org/13954011/diff/1/chrome/browser/chrome_browser... File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/13954011/diff/1/chrome/browser/chrome_browser... chrome/browser/chrome_browser_main.cc:1462: variations_service->StartRepeatedVariationsSeedFetch(); Could you explain why we chose to do the Android call to StartRepeated from here?
Anything we can TEST=?
https://codereview.chromium.org/13954011/diff/1/chrome/browser/chrome_browser... File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/13954011/diff/1/chrome/browser/chrome_browser... chrome/browser/chrome_browser_main.cc:1462: variations_service->StartRepeatedVariationsSeedFetch(); On 2013/04/18 15:24:53, SteveT wrote: > Could you explain why we chose to do the Android call to StartRepeated from > here? If you look down the #else codepath, that's where it's done for non-Android platforms. Since the #else path does a lot of other things unrelared to the VariationsService, I've just extracted the VariationsService bits to here.
LGTM Let's make sure there are some TEST= steps that talk about the seeing the dynamic variations after the first restart (that should occur, correct?).
On 2013/04/18 16:54:35, SteveT wrote: > LGTM > > Let's make sure there are some TEST= steps that talk about the seeing the > dynamic variations after the first restart (that should occur, correct?). Added a TEST= line, though it will require an official build to test.
+sky for chrome/ OWNERS review Will wait for Yusuf's change on the Chrome for Android side for the EULA pref, before I land this, though.
Err, sky is still OOO. +thakis for chrome/ OWNERS
lgtm Add 168224 to the BUG= line? https://codereview.chromium.org/13954011/diff/1/chrome/browser/chrome_browser... File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/13954011/diff/1/chrome/browser/chrome_browser... chrome/browser/chrome_browser_main.cc:1527: #endif nit: pull the body of the if into a StartVariations() function and call that here and up in the #if android block
https://codereview.chromium.org/13954011/diff/1/chrome/browser/chrome_browser... File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/13954011/diff/1/chrome/browser/chrome_browser... chrome/browser/chrome_browser_main.cc:1527: #endif On 2013/04/18 19:57:10, Nico wrote: > nit: pull the body of the if into a StartVariations() function and call that > here and up in the #if android block I see the motivation for this, but I think the end result would be a little bit confusing. That's because this isn't the first call into the VariationsService - since CreateTrialsFromSeed() gets called earlier during startup. So StartVariations() wouldn't strictly be starting up the VariationsService, since it has already been doing things prior to this. So I think I prefer to keep the current way for now, which is explicit as to what's actually being started.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13954011/1
Sorry for I got bad news for ya. Compile failed with a clobber build on win_x64_rel. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13954011/1
Sorry for I got bad news for ya. Compile failed with a clobber build on win_x64_rel. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13954011/1
Sorry for I got bad news for ya. Compile failed with a clobber build on win_x64_rel. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13954011/1
Sorry for I got bad news for ya. Compile failed with a clobber build on win_x64_rel. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13954011/1
Sorry for I got bad news for ya. Compile failed with a clobber build on win_x64_rel. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13954011/1
Sorry for I got bad news for ya. Compile failed with a clobber build on win_x64_rel. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/13954011/1
Message was sent while issue was closed.
Change committed as 195407 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
