Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1395493002: Improve error messages from checkperms PRESUBMIT check (Closed)

Created:
5 years, 2 months ago by Paweł Hajdan Jr.
Modified:
5 years, 2 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve error messages from checkperms PRESUBMIT check BUG=423697 Committed: https://crrev.com/5ea54792922a8dd0475ad0aa3aba7af5e02482cb Cr-Commit-Position: refs/heads/master@{#353993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M PRESUBMIT.py View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/PRESUBMIT.py View 1 chunk +11 lines, -9 lines 0 comments Download
M tools/checkperms/checkperms.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Paweł Hajdan Jr.
5 years, 2 months ago (2015-10-07 12:55:10 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-07 13:01:45 UTC) #3
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-13 18:28:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395493002/1
5 years, 2 months ago (2015-10-13 18:38:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/119982)
5 years, 2 months ago (2015-10-13 20:08:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395493002/1
5 years, 2 months ago (2015-10-14 08:10:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 10:51:19 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 10:51:59 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5ea54792922a8dd0475ad0aa3aba7af5e02482cb
Cr-Commit-Position: refs/heads/master@{#353993}

Powered by Google App Engine
This is Rietveld 408576698