Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1396733002: net: Move DiffServCodePoint enum out of net_util.h. (Closed)

Created:
5 years, 2 months ago by tfarina
Modified:
5 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, avayvod+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: Move DiffServCodePoint enum out of net_util.h. This patch moves DiffServCodePoint enum into its own header file under net/udp/diff_serv_code_point.h, to help breaking up net_util.h. BUG=488531 [email protected],[email protected] [email protected],[email protected],[email protected] Committed: https://crrev.com/42f7ce836a6930084b64da260cb150f8a468c336 Cr-Commit-Position: refs/heads/master@{#353133}

Patch Set 1 #

Patch Set 2 : fix dial_service_unittest.cc #

Total comments: 2

Patch Set 3 : fixes for win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -36 lines) Patch
M chrome/browser/extensions/api/dial/dial_service_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/net/udp_transport.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M net/base/net_util.h View 1 chunk +0 lines, -30 lines 0 comments Download
M net/net.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/udp/datagram_server_socket.h View 1 chunk +1 line, -1 line 0 comments Download
A net/udp/diff_serv_code_point.h View 1 chunk +42 lines, -0 lines 0 comments Download
M net/udp/udp_socket_posix.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/udp/udp_socket_win.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
tfarina
5 years, 2 months ago (2015-10-08 04:07:56 UTC) #1
mmenke
LGTM https://codereview.chromium.org/1396733002/diff/20001/media/cast/net/udp_transport.h File media/cast/net/udp_transport.h (right): https://codereview.chromium.org/1396733002/diff/20001/media/cast/net/udp_transport.h#newcode15 media/cast/net/udp_transport.h:15: #include "net/base/net_util.h" I don't think this is still ...
5 years, 2 months ago (2015-10-08 14:57:04 UTC) #3
eroman
udp_socket_win.h needs to be updated too. Otherwise LGTM
5 years, 2 months ago (2015-10-08 15:25:08 UTC) #4
tfarina
Also fixed udp_socket_win.h https://codereview.chromium.org/1396733002/diff/20001/media/cast/net/udp_transport.h File media/cast/net/udp_transport.h (right): https://codereview.chromium.org/1396733002/diff/20001/media/cast/net/udp_transport.h#newcode15 media/cast/net/udp_transport.h:15: #include "net/base/net_util.h" On 2015/10/08 14:57:04, mmenke ...
5 years, 2 months ago (2015-10-08 19:34:01 UTC) #5
tfarina
TBRing: miu for media/cast juberti for content/browser/renderer_host/p2p mfoltz for chrome/browser/extensions/api/dial
5 years, 2 months ago (2015-10-08 19:36:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396733002/40001
5 years, 2 months ago (2015-10-08 19:37:47 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-08 20:46:37 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/42f7ce836a6930084b64da260cb150f8a468c336 Cr-Commit-Position: refs/heads/master@{#353133}
5 years, 2 months ago (2015-10-08 20:47:32 UTC) #12
juberti2
5 years, 2 months ago (2015-10-09 02:47:34 UTC) #13
Message was sent while issue was closed. 
On 2015/10/08 20:47:32, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/42f7ce836a6930084b64da260cb150f8a468c336
> Cr-Commit-Position: refs/heads/master@{#353133}

lgtm for content/browser/renderer_host/p2p/socket_host_udp.h

Powered by Google App Engine
This is Rietveld 408576698