Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 140253014: QUIC - Moved FindOrNull and FindOrDie to a separate files. (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)
Modified:
6 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Visibility:
Public.

Description

QUIC - Moved FindOrNull and FindOrDie to a separate files. [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247139

Patch Set 1 : Used similarity to upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -149 lines) Patch
M net/net.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_utils.h View 3 chunks +2 lines, -65 lines 0 comments Download
A + net/quic/quic_utils_chromium.h View 2 chunks +7 lines, -83 lines 0 comments Download
A net/quic/quic_utils_chromium_test.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ramant (doing other things)
6 years, 11 months ago (2014-01-25 02:43:16 UTC) #1
Ryan Hamilton
lgtm
6 years, 11 months ago (2014-01-25 03:28:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/140253014/2
6 years, 11 months ago (2014-01-25 07:31:13 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=194889
6 years, 11 months ago (2014-01-25 09:04:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/140253014/2
6 years, 11 months ago (2014-01-25 16:33:17 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-25 20:32:54 UTC) #6
Message was sent while issue was closed.
Change committed as 247139

Powered by Google App Engine
This is Rietveld 408576698