Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413193009: Remove the kMaxSegmentSize constant from QUIC's TcpCubicSender and TcpCubicBytesSender and replace … (Closed)

Created:
5 years, 1 month ago by Ryan Hamilton
Modified:
5 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@106333315
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the kMaxSegmentSize constant from QUIC's TcpCubicSender and TcpCubicBytesSender and replace with the identical kDefaultTCPMSS. Also fixes an error where the bandwidth resumption check was incorrectly using kMaxPacketSize. Changes bandwidth resumption CWNDs by less than 1%. Merge internal change: 106356338 [email protected] BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M net/quic/congestion_control/tcp_cubic_bytes_sender.cc View 8 chunks +14 lines, -15 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1417533011 Patch 1

Dependent Patchsets:

Issue 1421703005 Patch 1

Messages

Total messages: 4 (2 generated)
Ryan Hamilton
5 years, 1 month ago (2015-11-02 19:08:40 UTC) #1
ramant (doing other things)
5 years, 1 month ago (2015-11-03 00:40:37 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698