Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1431693002: Change QuicAckFrame's revived_packets to be a single QuicPacketNumber. QUIC now ignores all but the… (Closed)

Created:
5 years, 1 month ago by Ryan Hamilton
Modified:
5 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@106724344
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change QuicAckFrame's revived_packets to be a single QuicPacketNumber. QUIC now ignores all but the last packet revived by FEC. Consumes 24 bytes less and is faster and simpler. Merge internal change: 106729701 [email protected] BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -53 lines) Patch
M net/quic/quic_connection.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_framer.cc View 4 chunks +14 lines, -13 lines 0 comments Download
M net/quic/quic_framer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M net/quic/quic_received_packet_manager.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M net/quic/quic_received_packet_manager_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (2 generated)
Ryan Hamilton
5 years, 1 month ago (2015-11-02 23:37:58 UTC) #1
ramant (doing other things)
5 years, 1 month ago (2015-11-03 00:25:19 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698