Issue 151003008: Fix crash in ExtensionFunctionDispatcher due to invalid Profile/BrowserContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151003008: Fix crash in ExtensionFunctionDispatcher due to invalid Profile/BrowserContext (Closed)

Created:
6 years, 10 months ago by James Cook

Modified:
6 years, 10 months ago

Reviewers:
benwells

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix crash in ExtensionFunctionDispatcher due to invalid Profile/BrowserContext The Profile may be closed (and hence the BrowserContext becomes invalid) after the LogSuccess task is posted to the UI thread. We don't care about logging function call activity for a profile that just closed, so skip the logging. BUG=341195 TEST=existing extensions browser_tests [email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249470

Patch Set 1 #

Total comments: 1

Patch Set 2 : trivial rebase #

Patch Set 3 : formatting #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	chrome/browser/extensions/extension_function_dispatcher.cc	View	1 2	3 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

benwells

lgtm with a nit. https://codereview.chromium.org/151003008/diff/1/chrome/browser/extensions/extension_function_dispatcher.cc File chrome/browser/extensions/extension_function_dispatcher.cc (right): https://codereview.chromium.org/151003008/diff/1/chrome/browser/extensions/extension_function_dispatcher.cc#newcode71 chrome/browser/extensions/extension_function_dispatcher.cc:71: return; Nit: blank line after ...

6 years, 10 months ago (2014-02-06 01:46:36 UTC) #2

James Cook

6 years, 10 months ago (2014-02-06 19:29:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r249470 (presubmit successful).

Expand Messages | Collapse Messages