Issue 1513014: Changes browser_tests to not run a nested message loop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1513014: Changes browser_tests to not run a nested message loop. (Closed)

Created:
10 years, 8 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli, Paweł Hajdan Jr.

CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr., viettrungluu

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Changes browser_tests to not run a nested message loop. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44004

Patch Set 6 : '' #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -13 lines)			Patch
M	chrome/browser/browser_main.cc	View	1 2 3 4 5	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/test/in_process_browser_test.h	View	1 2 3 4 5	1 chunk	+13 lines, -2 lines	0 comments	Download
M	chrome/test/in_process_browser_test.cc	View	1 2 3 4 5	4 chunks	+59 lines, -11 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

After fixing the nit LGTM. Thanks! http://codereview.chromium.org/1513014/diff/23001/24002 File chrome/test/in_process_browser_test.cc (right): http://codereview.chromium.org/1513014/diff/23001/24002#newcode305 chrome/test/in_process_browser_test.cc:305: #endif nit: // ...

10 years, 8 months ago (2010-04-08 19:27:50 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 1513014: Changes browser_tests to not run a nested message loop. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Messages