Add about:flags to enable non-validating reload on pull-to-refresh

Add about:flags to enable non-validating reload on pull-to-refresh

BUG=558829
TEST=manual

Committed: https://crrev.com/8f7b4064aced5c2b7a3a3331888e8f53e798e9ee
Cr-Commit-Position: refs/heads/master@{#366040}

[kinuko, 2015-12-16 14:31:27]

Description was changed from

==========
Add about:flags to enable non-validating reload on pull-to-refresh

BUG=558829
==========

to

==========
Add about:flags to enable non-validating reload on pull-to-refresh

BUG=558829
TEST=manual
==========

[kinuko, 2015-12-16 14:32:17]

[email protected] changed reviewers:
+ [email protected]

[tyoshino (SeeGerritForStatus), 2015-12-17 04:23:51]

https://codereview.chromium.org/1534433003/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1534433003/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:6117: +          Forces pull-to-refresh
trigger non-validating reload (while it usually means regular, cache-validating
reload when the flag id disabled).
remove "id"? disabling id sounds weird.

https://codereview.chromium.org/1534433003/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1534433003/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:1062:
IDS_FLAGS_ENABLE_NON_VALIDATING_RELOAD_ON_REFRESH_CONTENT,
_NAME? The neighbors don't have it, but most entries have it.

https://codereview.chromium.org/1534433003/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:1064: kOsAll,
kOsAndroid

[kinuko, 2015-12-17 05:46:46]

Thanks, updated.

https://codereview.chromium.org/1534433003/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1534433003/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:6117: +          Forces pull-to-refresh
trigger non-validating reload (while it usually means regular, cache-validating
reload when the flag id disabled).
On 2015/12/17 04:23:51, tyoshino wrote:
> remove "id"? disabling id sounds weird.

Was typo, replaced with "is".

https://codereview.chromium.org/1534433003/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1534433003/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:1062:
IDS_FLAGS_ENABLE_NON_VALIDATING_RELOAD_ON_REFRESH_CONTENT,
On 2015/12/17 04:23:51, tyoshino wrote:
> _NAME? The neighbors don't have it, but most entries have it.

Done.

https://codereview.chromium.org/1534433003/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:1064: kOsAll,
On 2015/12/17 04:23:51, tyoshino wrote:
> kOsAndroid

Done.

[kinuko, 2015-12-17 06:55:35]

Um, no this change is not ready yet.

[kinuko, 2015-12-17 09:25:38]

[email protected] changed reviewers:
+ [email protected]

[kinuko, 2015-12-17 11:29:45]

Ok, fixed the test.

tyoshino@: PTL

asvitkine@: PTL the histogram changes

Thanks!

[Alexei Svitkine (slow), 2015-12-17 16:10:01]

lgtm

[tyoshino (SeeGerritForStatus), 2015-12-18 07:18:35]

lgtm

[kinuko, 2015-12-18 07:19:45]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2015-12-18 07:20:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534433003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534433003/40001

[commit-bot: I haz the power, 2015-12-18 07:24:30]

Description was changed from

==========
Add about:flags to enable non-validating reload on pull-to-refresh

BUG=558829
TEST=manual
==========

to

==========
Add about:flags to enable non-validating reload on pull-to-refresh

BUG=558829
TEST=manual
==========

[commit-bot: I haz the power, 2015-12-18 07:24:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-18 07:25:36]

Description was changed from

==========
Add about:flags to enable non-validating reload on pull-to-refresh

BUG=558829
TEST=manual
==========

to

==========
Add about:flags to enable non-validating reload on pull-to-refresh

BUG=558829
TEST=manual

Committed: https://crrev.com/8f7b4064aced5c2b7a3a3331888e8f53e798e9ee
Cr-Commit-Position: refs/heads/master@{#366040}
==========

[commit-bot: I haz the power, 2015-12-18 07:25:37]

Patchset 3 (id:??) landed as
https://crrev.com/8f7b4064aced5c2b7a3a3331888e8f53e798e9ee
Cr-Commit-Position: refs/heads/master@{#366040}