Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15371005: Move browser-specific FileAPI code from webkit/fileapi to webkit/browser/fileapi (Closed)

Created:
7 years, 7 months ago by kinuko
Modified:
7 years, 7 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, jam, sail+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move browser-specific FileAPI code from webkit/fileapi to webkit/browser/fileapi Moves following files (14 files, 41/130 -> 55/130): - file_system_file_util* - isolated_file_util* - local_file_util* - native_file_util* - transient_file_util* BUG=239710 [email protected],[email protected] Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201503

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -2657 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/filtering_file_enumerator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes/itunes_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_object_enumerator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/blob/blob_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/file_system_file_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/file_system_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/isolated_file_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/fileapi/isolated_file_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/browser/fileapi/isolated_file_util_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/local_file_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/fileapi/local_file_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/browser/fileapi/local_file_util_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webkit/browser/fileapi/native_file_util.h View 4 chunks +8 lines, -6 lines 0 comments Download
A + webkit/browser/fileapi/native_file_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
A + webkit/browser/fileapi/native_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/transient_file_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/browser/fileapi/transient_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/browser/fileapi/transient_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/webkit_browser_fileapi.gypi View 3 chunks +10 lines, -0 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/fileapi/async_file_util_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_file_stream_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D webkit/fileapi/file_system_file_util.h View 1 chunk +0 lines, -189 lines 0 comments Download
D webkit/fileapi/file_system_file_util.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M webkit/fileapi/file_writer_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D webkit/fileapi/isolated_file_util.h View 1 chunk +0 lines, -52 lines 0 comments Download
D webkit/fileapi/isolated_file_util.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D webkit/fileapi/isolated_file_util_unittest.cc View 1 chunk +0 lines, -553 lines 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/fileapi/local_file_system_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/local_file_system_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/local_file_system_operation_write_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/local_file_system_quota_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/local_file_system_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
D webkit/fileapi/local_file_util.h View 1 chunk +0 lines, -104 lines 0 comments Download
D webkit/fileapi/local_file_util.cc View 1 chunk +0 lines, -264 lines 0 comments Download
D webkit/fileapi/local_file_util_unittest.cc View 1 chunk +0 lines, -370 lines 0 comments Download
D webkit/fileapi/native_file_util.h View 1 chunk +0 lines, -66 lines 0 comments Download
D webkit/fileapi/native_file_util.cc View 1 chunk +0 lines, -264 lines 0 comments Download
D webkit/fileapi/native_file_util_unittest.cc View 1 chunk +0 lines, -341 lines 0 comments Download
M webkit/fileapi/syncable/local_file_change_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/local_file_sync_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/test_mount_point_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D webkit/fileapi/transient_file_util.h View 1 chunk +0 lines, -36 lines 0 comments Download
D webkit/fileapi/transient_file_util.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D webkit/fileapi/transient_file_util_unittest.cc View 1 chunk +0 lines, -122 lines 0 comments Download
M webkit/fileapi/upload_file_system_file_element_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kinuko
ptl
7 years, 7 months ago (2013-05-21 12:56:11 UTC) #1
tzik
lgtm
7 years, 7 months ago (2013-05-22 04:07:50 UTC) #2
kinuko
TBR=avi,thestig for content/content_tests and chrome/ changes. Thx!
7 years, 7 months ago (2013-05-22 11:35:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/15371005/1
7 years, 7 months ago (2013-05-22 11:35:50 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-22 11:59:43 UTC) #5
kinuko
Committed patchset #2 manually as r201503 (presubmit successful).
7 years, 7 months ago (2013-05-22 12:54:39 UTC) #6
Avi (use Gerrit)
lgtm stamp of approval
7 years, 7 months ago (2013-05-22 14:30:47 UTC) #7
Lei Zhang
7 years, 7 months ago (2013-05-22 17:57:19 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698