n/a (quic toy client)

If message body specified with --body_hex then print out the user provided
string rather than the binary body.

n/a (quic toy client)

Merge internal change: 110244865

[email protected]
BUG=26183146

[Ryan Hamilton, 2015-12-21 17:39:29]

https://codereview.chromium.org/1538373002/diff/1/net/tools/quic/quic_client_...
File net/tools/quic/quic_client_bin.cc (right):

https://codereview.chromium.org/1538373002/diff/1/net/tools/quic/quic_client_...
net/tools/quic/quic_client_bin.cc:341: body_to_print = StrCat("(hex) 0x",
FLAGS_body_hex);
Does this compile? I don't think we have StrCat in chromium. You'll want to
build quic_client, epoll_quic_client

Also you'll need to change quic_simple_client_bin.cc

[Fan Yang, 2015-12-21 20:57:07]

Patchset #3 (id:40001) has been deleted

[Fan Yang, 2015-12-21 20:59:46]

Patchset #2 (id:20001) has been deleted

[Fan Yang, 2015-12-21 22:07:44]

Patchset #2 (id:60001) has been deleted

[Fan Yang, 2015-12-21 22:08:42]

On 2015/12/21 17:39:29, Ryan Hamilton wrote:
>
https://codereview.chromium.org/1538373002/diff/1/net/tools/quic/quic_client_...
> File net/tools/quic/quic_client_bin.cc (right):
> 
>
https://codereview.chromium.org/1538373002/diff/1/net/tools/quic/quic_client_...
> net/tools/quic/quic_client_bin.cc:341: body_to_print = StrCat("(hex) 0x",
> FLAGS_body_hex);
> Does this compile? I don't think we have StrCat in chromium. You'll want to
> build quic_client, epoll_quic_client
> 
> Also you'll need to change quic_simple_client_bin.cc

Thanks Ryan, PTAL.

[Fan Yang, 2015-12-21 22:08:43]

On 2015/12/21 17:39:29, Ryan Hamilton wrote:
>
https://codereview.chromium.org/1538373002/diff/1/net/tools/quic/quic_client_...
> File net/tools/quic/quic_client_bin.cc (right):
> 
>
https://codereview.chromium.org/1538373002/diff/1/net/tools/quic/quic_client_...
> net/tools/quic/quic_client_bin.cc:341: body_to_print = StrCat("(hex) 0x",
> FLAGS_body_hex);
> Does this compile? I don't think we have StrCat in chromium. You'll want to
> build quic_client, epoll_quic_client
> 
> Also you'll need to change quic_simple_client_bin.cc

Thanks Ryan, PTAL.

[Ryan Hamilton, 2015-12-21 22:30:34]

lgtm

[Fan Yang, 2015-12-22 22:34:37]

Description was changed from

==========
n/a (quic toy client)

If message body specified with --body_hex then print out the user provided
string rather than the binary body.

Merge internal change: 110244865

[email protected]
[email protected]
BUG=26183146
==========

to

==========
If message body specified with --body_hex then print out the user provided
string rather than the binary body.

n/a (quic toy client)

Merge internal change: 110244865

[email protected]
BUG=26183146
==========