Issue 1559173002: Make headers self-contained

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1559173002: Make headers self-contained (Closed)

Created:
4 years, 11 months ago by Jo Kulik

Modified:
4 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@111087405

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make headers self-contained Un-disable header parsing in BUILD files to ensure that headers are self-contained. Fix up headers and BUILD files to add missing dependencies. There are only a few targets where I explicitly disabled parsing for especially troublesome headers. I'll fix those in a follow-up CL. Merge internal change: 111129322 [email protected] BUG=

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	net/quic/quic_protocol.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1556283002 Patch 1

Dependent Patchsets:

Issue 1556023003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages