Make checkbox in bookmark app creation dialog sticky across app creations.

Make checkbox in bookmark app creation dialog sticky across app creations.

This CL makes the "Open as tab" checkbox in the bookmark app creation
dialog sticky by adding a profile pref tracking the last launch type set.

BUG=318607
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250354

[benwells, 2014-02-06 07:21:22]

lgtm

[calamity, 2014-02-06 07:31:57]

+sky for chrome/browser/ui/ OWNERS.

[sky, 2014-02-06 17:27:10]

LGTM

[calamity, 2014-02-06 23:50:52]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-02-06 23:51:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/156513002/1

[commit-bot: I haz the power, 2014-02-07 00:19:17]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2014-02-07 00:19:17]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[calamity, 2014-02-07 05:17:17]

benwells@, could you PTAL? 

Moved the pref registration to launch_util.cc.

Thanks.

[benwells, 2014-02-07 06:27:17]

https://codereview.chromium.org/156513002/diff/340001/chrome/browser/prefs/br...
File chrome/browser/prefs/browser_prefs.cc (right):

https://codereview.chromium.org/156513002/diff/340001/chrome/browser/prefs/br...
chrome/browser/prefs/browser_prefs.cc:347:
extensions::RegisterProfilePrefs(registry);
This doesn't feel right. If we have this as extensions::RegisterProfilePrefs it
should be in a central place like chrome/browser/extensions/pref_names.

Or if it is just launch things it should be something like
extensions::LaunchUtils::RegisterProfilePrefs.

Either is fine by me but maybe Yoyo has an opinion.

[Yoyo Zhou, 2014-02-07 18:59:45]

https://codereview.chromium.org/156513002/diff/340001/chrome/browser/prefs/br...
File chrome/browser/prefs/browser_prefs.cc (right):

https://codereview.chromium.org/156513002/diff/340001/chrome/browser/prefs/br...
chrome/browser/prefs/browser_prefs.cc:347:
extensions::RegisterProfilePrefs(registry);
On 2014/02/07 06:27:17, benwells wrote:
> This doesn't feel right. If we have this as extensions::RegisterProfilePrefs
it
> should be in a central place like chrome/browser/extensions/pref_names.
> 
> Or if it is just launch things it should be something like
> extensions::LaunchUtils::RegisterProfilePrefs.
> 
> Either is fine by me but maybe Yoyo has an opinion.

It does read strangely compared to the ones below it.

extensions::LaunchUtil::RegisterProfilePrefs would be my pref. (Or
extensions::launch_util::...) No need to refactor the rest of launch_util in
this CL, though it would be nice to have consistency.

[calamity, 2014-02-10 10:06:50]

https://codereview.chromium.org/156513002/diff/340001/chrome/browser/prefs/br...
File chrome/browser/prefs/browser_prefs.cc (right):

https://codereview.chromium.org/156513002/diff/340001/chrome/browser/prefs/br...
chrome/browser/prefs/browser_prefs.cc:347:
extensions::RegisterProfilePrefs(registry);
On 2014/02/07 18:59:45, Yoyo Zhou wrote:
> On 2014/02/07 06:27:17, benwells wrote:
> > This doesn't feel right. If we have this as extensions::RegisterProfilePrefs
> it
> > should be in a central place like chrome/browser/extensions/pref_names.
> > 
> > Or if it is just launch things it should be something like
> > extensions::LaunchUtils::RegisterProfilePrefs.
> > 
> > Either is fine by me but maybe Yoyo has an opinion.
> 
> It does read strangely compared to the ones below it.
> 
> extensions::LaunchUtil::RegisterProfilePrefs would be my pref. (Or
> extensions::launch_util::...) No need to refactor the rest of launch_util in
> this CL, though it would be nice to have consistency.

Moved it into launch_util namespace.

[Yoyo Zhou, 2014-02-10 19:50:47]

LGTM

[Yoyo Zhou, 2014-02-10 19:50:56]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-02-10 19:53:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/156513002/410001

[commit-bot: I haz the power, 2014-02-10 19:53:13]

The CQ bit was unchecked by [email protected]

[commit-bot: I haz the power, 2014-02-10 19:53:15]

Failed to apply patch for chrome/browser/prefs/browser_prefs.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/prefs/browser_prefs.cc
  Hunk #1 FAILED at 27.
  Hunk #2 FAILED at 345.
  2 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/prefs/browser_prefs.cc.rej

Patch:       chrome/browser/prefs/browser_prefs.cc
Index: chrome/browser/prefs/browser_prefs.cc
diff --git a/chrome/browser/prefs/browser_prefs.cc
b/chrome/browser/prefs/browser_prefs.cc
index
b443a350c36b7a7d85cbf92b795631c769aabf7f..84d592f95f52f2a831619e3852d23e0cef3235a4
100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -27,6 +27,7 @@
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
 #include "chrome/browser/extensions/extension_web_ui.h"
 #include "chrome/browser/extensions/external_component_loader.h"
+#include "chrome/browser/extensions/launch_util.h"
 #include "chrome/browser/external_protocol/external_protocol_handler.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/geolocation/geolocation_prefs.h"
@@ -345,6 +346,7 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable*
registry) {
   DownloadPrefs::RegisterProfilePrefs(registry);
   extensions::ExtensionPrefs::RegisterProfilePrefs(registry);
   extensions::ExternalComponentLoader::RegisterProfilePrefs(registry);
+  extensions::launch_util::RegisterProfilePrefs(registry);
   ExtensionWebUI::RegisterProfilePrefs(registry);
   HostContentSettingsMap::RegisterProfilePrefs(registry);
   IncognitoModePrefs::RegisterProfilePrefs(registry);

[calamity, 2014-02-11 02:48:23]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2014-02-11 02:48:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/[email protected]/156513002/570001

[commit-bot: I haz the power, 2014-02-11 04:59:13]

Change committed as 250354