Upstream iOS SSL blocking page.

Upstream iOS SSL blocking page.

BUG=574038
Committed: https://crrev.com/c64fc33a50d775cca8af388024ebdc448fc0297a
Cr-Commit-Position: refs/heads/master@{#367879}

[sdefresne, 2016-01-06 17:02:48]

[email protected] changed reviewers:
+ [email protected]

[sdefresne, 2016-01-06 17:02:48]

Please take a look.

[droger, 2016-01-06 17:21:23]

LGTM with comment below

https://codereview.chromium.org/1566753002/diff/1/ios/chrome/browser/ssl/ios_...
File ios/chrome/browser/ssl/ios_ssl_blocking_page.h (right):

https://codereview.chromium.org/1566753002/diff/1/ios/chrome/browser/ssl/ios_...
ios/chrome/browser/ssl/ios_ssl_blocking_page.h:32: class IOSSSLBlockingPage :
public IOSSecurityInterstitialPage {
Should it be IOSChromeSSLBlockingPage?

[droger, 2016-01-06 17:22:37]

Can you add a OWNER file matching the OWNERs for the other implementation?

[droger, 2016-01-06 17:28:03]

https://codereview.chromium.org/1566753002/diff/1/ios/chrome/browser/ssl/ios_...
File ios/chrome/browser/ssl/ios_ssl_blocking_page.cc (right):

https://codereview.chromium.org/1566753002/diff/1/ios/chrome/browser/ssl/ios_...
ios/chrome/browser/ssl/ios_ssl_blocking_page.cc:40: const char
kSSLRapporPrefix[] = "ssl2";
Probably not for this CL, but it seems that it would be possible to componentize
and share more code. Examples:
- kSSLRapporPrefix
- RecordSSLExpirationPageEventState()
- the constants like "errorCode" on line 139.

[sdefresne, 2016-01-06 17:31:03]

Thank you for the review.

https://codereview.chromium.org/1566753002/diff/1/ios/chrome/browser/ssl/ios_...
File ios/chrome/browser/ssl/ios_ssl_blocking_page.cc (right):

https://codereview.chromium.org/1566753002/diff/1/ios/chrome/browser/ssl/ios_...
ios/chrome/browser/ssl/ios_ssl_blocking_page.cc:40: const char
kSSLRapporPrefix[] = "ssl2";
On 2016/01/06 at 17:28:03, droger wrote:
> Probably not for this CL, but it seems that it would be possible to
componentize and share more code. Examples:
> - kSSLRapporPrefix
> - RecordSSLExpirationPageEventState()
> - the constants like "errorCode" on line 139.

https://code.google.com/p/chromium/issues/detail?id=574858

https://codereview.chromium.org/1566753002/diff/1/ios/chrome/browser/ssl/ios_...
File ios/chrome/browser/ssl/ios_ssl_blocking_page.h (right):

https://codereview.chromium.org/1566753002/diff/1/ios/chrome/browser/ssl/ios_...
ios/chrome/browser/ssl/ios_ssl_blocking_page.h:32: class IOSSSLBlockingPage :
public IOSSecurityInterstitialPage {
On 2016/01/06 at 17:21:23, droger wrote:
> Should it be IOSChromeSSLBlockingPage?

Maybe, however superclass is also named IOSSecurityInterstitialPage, so naming
it IOSSSLBlockingPage is closer. Maybe I should also rename superclass too. Can
this be done in a followup CL?

[droger, 2016-01-06 17:34:00]

https://codereview.chromium.org/1566753002/diff/1/ios/chrome/browser/ssl/ios_...
File ios/chrome/browser/ssl/ios_ssl_blocking_page.h (right):

https://codereview.chromium.org/1566753002/diff/1/ios/chrome/browser/ssl/ios_...
ios/chrome/browser/ssl/ios_ssl_blocking_page.h:32: class IOSSSLBlockingPage :
public IOSSecurityInterstitialPage {
On 2016/01/06 17:31:02, sdefresne wrote:
> On 2016/01/06 at 17:21:23, droger wrote:
> > Should it be IOSChromeSSLBlockingPage?
> 
> Maybe, however superclass is also named IOSSecurityInterstitialPage, so naming
> it IOSSSLBlockingPage is closer. Maybe I should also rename superclass too.
Can
> this be done in a followup CL?

Sure, that's fine.

[sdefresne, 2016-01-06 18:45:11]

The CQ bit was checked by [email protected]

[sdefresne, 2016-01-06 18:45:11]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected]
Link to the patchset: https://codereview.chromium.org/1566753002/#ps20001
(title: "Add OWNERS file")

[commit-bot: I haz the power, 2016-01-06 18:45:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1566753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1566753002/20001

[commit-bot: I haz the power, 2016-01-06 19:36:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-06 19:37:41]

Description was changed from

==========
Upstream iOS SSL blocking page.

BUG=574038
==========

to

==========
Upstream iOS SSL blocking page.

BUG=574038

Committed: https://crrev.com/c64fc33a50d775cca8af388024ebdc448fc0297a
Cr-Commit-Position: refs/heads/master@{#367879}
==========

[commit-bot: I haz the power, 2016-01-06 19:37:42]

Patchset 2 (id:??) landed as
https://crrev.com/c64fc33a50d775cca8af388024ebdc448fc0297a
Cr-Commit-Position: refs/heads/master@{#367879}