Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1581283002: Rename chromium-specific QUIC classes. (Closed)

Created:
4 years, 11 months ago by Ryan Hamilton
Modified:
4 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename chromium-specific QUIC classes. Committed: https://crrev.com/12fef55822ccb213cafb8dfab89b8644dd0eb307 Cr-Commit-Position: refs/heads/master@{#369761}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : rebase #

Patch Set 4 : add missing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -1049 lines) Patch
M net/net.gypi View 5 chunks +6 lines, -6 lines 0 comments Download
M net/quic/p2p/quic_p2p_session_test.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_chromium_client_session.h View 1 7 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_chromium_client_session.cc View 1 7 chunks +9 lines, -9 lines 0 comments Download
M net/quic/quic_chromium_client_session_test.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
A + net/quic/quic_chromium_client_stream.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + net/quic/quic_chromium_client_stream.cc View 11 chunks +21 lines, -21 lines 0 comments Download
A + net/quic/quic_chromium_client_stream_test.cc View 9 chunks +17 lines, -17 lines 0 comments Download
A + net/quic/quic_chromium_connection_helper.h View 1 2 3 3 chunks +8 lines, -9 lines 0 comments Download
A + net/quic/quic_chromium_connection_helper.cc View 1 2 3 2 chunks +11 lines, -9 lines 0 comments Download
A + net/quic/quic_chromium_connection_helper_test.cc View 1 2 3 6 chunks +11 lines, -11 lines 0 comments Download
D net/quic/quic_connection_helper.h View 1 chunk +0 lines, -58 lines 0 comments Download
D net/quic/quic_connection_helper.cc View 1 chunk +0 lines, -120 lines 0 comments Download
D net/quic/quic_connection_helper_test.cc View 1 chunk +0 lines, -189 lines 0 comments Download
M net/quic/quic_http_stream.h View 4 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_http_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 2 7 chunks +12 lines, -12 lines 0 comments Download
D net/quic/quic_reliable_client_stream.h View 1 chunk +0 lines, -116 lines 0 comments Download
D net/quic/quic_reliable_client_stream.cc View 1 chunk +0 lines, -178 lines 0 comments Download
D net/quic/quic_reliable_client_stream_test.cc View 1 chunk +0 lines, -244 lines 0 comments Download
M net/quic/quic_stream_factory.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_client.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M net/tools/quic/quic_simple_server.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_server.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 40 (21 generated)
Ryan Hamilton
4 years, 11 months ago (2016-01-14 01:06:50 UTC) #3
ramant (doing other things)
lgtm
4 years, 11 months ago (2016-01-14 01:26:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581283002/1
4 years, 11 months ago (2016-01-14 03:04:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/116866) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-14 03:18:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581283002/1
4 years, 11 months ago (2016-01-14 03:42:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/116557) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, ...
4 years, 11 months ago (2016-01-14 03:46:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581283002/1
4 years, 11 months ago (2016-01-14 04:21:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/116883) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-14 04:35:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581283002/1
4 years, 11 months ago (2016-01-14 17:34:44 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/117094) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-14 17:37:40 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581283002/20001
4 years, 11 months ago (2016-01-15 00:21:11 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/159047) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-15 00:28:53 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581283002/20001
4 years, 11 months ago (2016-01-15 05:02:30 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/53151)
4 years, 11 months ago (2016-01-15 05:09:01 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581283002/40001
4 years, 11 months ago (2016-01-15 14:58:18 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/117704) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-15 15:06:17 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581283002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581283002/60001
4 years, 11 months ago (2016-01-15 15:11:09 UTC) #37
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-15 16:26:39 UTC) #38
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 16:28:13 UTC) #40
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/12fef55822ccb213cafb8dfab89b8644dd0eb307
Cr-Commit-Position: refs/heads/master@{#369761}

Powered by Google App Engine
This is Rietveld 408576698