List message decryption failures on chrome://gcm-internals

List message decryption failures on chrome://gcm-internals

This CL is basically just plumbing of a result code to an internal
diagnosis page. Decryption is done at the level of the GCM Driver,
while, for desktop, the GCMStatsRecorder is owned by the GCMClient
several layers down, on another thread.

BUG=569127
Committed: https://crrev.com/3b13f04b739480acc7d449ef5c4ba0157bb538b5
Cr-Commit-Position: refs/heads/master@{#371084}

[Peter Beverloo, 2016-01-21 20:16:46]

[email protected] changed reviewers:
+ [email protected]

[Peter Beverloo, 2016-01-21 20:16:46]

+jianli

While this needs a few more tests, getting your high-level thoughts would be
good. It's literally all plumbing :-(.

[jianli, 2016-01-21 23:07:19]

lgtm

Do you also need to update DEPS?

Also, please investigate abdroid trybot failures.

[Peter Beverloo, 2016-01-22 15:16:55]

Patchset #3 (id:40001) has been deleted

[Peter Beverloo, 2016-01-22 15:19:58]

On 2016/01/21 23:07:19, jianli wrote:
> lgtm
> 
> Do you also need to update DEPS?
> 
> Also, please investigate abdroid trybot failures.

Done, fixed the failure (typo).

I added a test in gcm_driver_desktop_unittest.cc that verifies the integration
at the GCMDriver(Desktop) level, for which I gave FakeGCMClient a
GCMStatsRecorderImpl. Since there won't be a (Fake)GCMClient at all on Android,
I think this is OK.

If you agree, would you mind putting this on the CQ? :-)

[jianli, 2016-01-22 21:58:53]

The CQ bit was checked by [email protected]

[jianli, 2016-01-22 21:58:54]

lgtm

[commit-bot: I haz the power, 2016-01-22 22:00:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616113003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616113003/80001

[commit-bot: I haz the power, 2016-01-22 23:44:39]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-01-22 23:45:35]

Description was changed from

==========
List message decryption failures on chrome://gcm-internals

This CL is basically just plumbing of a result code to an internal
diagnosis page. Decryption is done at the level of the GCM Driver,
while, for desktop, the GCMStatsRecorder is owned by the GCMClient
several layers down, on another thread.

BUG=569127
==========

to

==========
List message decryption failures on chrome://gcm-internals

This CL is basically just plumbing of a result code to an internal
diagnosis page. Decryption is done at the level of the GCM Driver,
while, for desktop, the GCMStatsRecorder is owned by the GCMClient
several layers down, on another thread.

BUG=569127

Committed: https://crrev.com/3b13f04b739480acc7d449ef5c4ba0157bb538b5
Cr-Commit-Position: refs/heads/master@{#371084}
==========

[commit-bot: I haz the power, 2016-01-22 23:45:36]

Patchset 4 (id:??) landed as
https://crrev.com/3b13f04b739480acc7d449ef5c4ba0157bb538b5
Cr-Commit-Position: refs/heads/master@{#371084}

[Nico, 2016-01-23 23:03:07]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/1627723002/ by [email protected].

The reason for reverting is: The test added in this CL is failing fairly
reliably on
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg)

GCMDriverFunctionalTest.EncryptedMessageReceivedError: 
[9766:1803:0122/171135:1228193336123:ERROR:gcm_encryption_provider.cc(136)]
Invalid values supplied in the Crypto-Key header
/b/build/slave/iOS_Simulator__dbg_/build/src/components/gcm_driver/gcm_driver_desktop_unittest.cc:835:
Failure
Value of: statistics.recorded_activities.decryption_failure_activities.size()
  Actual: 0
Expected: 1u
Which is: 1.