Introduce PPB_TCPSocket_Dev.

ppapi/proxy/ppapi_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message header, no traditional include guard.
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
@@ skipping 665 matching lines @@
                     PP_Instance /* instance */,
                     PP_DecryptorStreamType /* decoder_type */,
                     uint32_t /* request_id */)
 IPC_MESSAGE_ROUTED4(PpapiMsg_PPPContentDecryptor_DecryptAndDecode,
                     PP_Instance /* instance */,
                     PP_DecryptorStreamType /* decoder_type */,
                     ppapi::proxy::PPPDecryptor_Buffer /* buffer */,
                     std::string /* serialized_block_info */)
 #endif  // !defined(OS_NACL) && !defined(NACL_WIN64)
 
-// PPB_TCPSocket_Private.
+// PPB_TCPSocket and PPB_TCPSocket_Private.
 IPC_MESSAGE_ROUTED5(PpapiMsg_PPBTCPSocket_ConnectACK,
                     uint32 /* plugin_dispatcher_id */,
                     uint32 /* socket_id */,
                     bool /* succeeded */,
                     PP_NetAddress_Private /* local_addr */,
                     PP_NetAddress_Private /* remote_addr */)
 IPC_MESSAGE_ROUTED4(PpapiMsg_PPBTCPSocket_SSLHandshakeACK,
                     uint32 /* plugin_dispatcher_id */,
                     uint32 /* socket_id */,
                     bool /* succeeded */,
@@ skipping 464 matching lines @@
 IPC_SYNC_MESSAGE_ROUTED1_1(PpapiHostMsg_PPBFlashMessageLoop_Create,
                            PP_Instance /* instance */,
                            ppapi::HostResource /* result */)
 IPC_SYNC_MESSAGE_ROUTED1_1(PpapiHostMsg_PPBFlashMessageLoop_Run,
                            ppapi::HostResource /* flash_message_loop */,
                            int32_t /* result */)
 IPC_SYNC_MESSAGE_ROUTED1_0(PpapiHostMsg_PPBFlashMessageLoop_Quit,
                            ppapi::HostResource /* flash_message_loop */)
 #endif  // !defined(OS_NACL) && !defined(NACL_WIN64)
 
-// PPB_TCPSocket_Private.
+// PPB_TCPSocket and PPB_TCPSocket_Private.
 IPC_SYNC_MESSAGE_CONTROL2_1(PpapiHostMsg_PPBTCPSocket_Create,

[dmichael (off chromium), 2013/06/10 22:31:35]

I'm a little concerned about using the same exact backend with no checking of
dev vs private permissions. A compromised renderer will be able to use the SSL
stuff (not sure if that's a security concern or not). But in any case it's
strange that creation of PPB_TCPSocket_Dev is governed by whether private
interfaces are allowed.

[yzshen1, 2013/06/11 15:05:48]

I agree that we must check permissions at the backend to distinguish the dev and
private API.
I haven't added the code to do the apps permission check yet. I am planning to
do the work in a separate CL.

I think we need to make sure that the SSL related code is disallowed for
non-whitelisted apps; other operations can be allowed for both apps with
permission and whitelisted apps.
The creation of PPB_TCPSocket_Dev is not governed by whether private interfaces
are allowed.

The current backend in the browser process doesn't check anything when creating
a socket object. In other words, anyone can create private socket resources, the
problem is that those non-whitelisted apps will fail when calling
connect/sendto/listen.

On 2013/06/10 22:31:35, dmichael wrote:

                             int32 /* routing_id */,
                             uint32 /* plugin_dispatcher_id */,
                             uint32 /* socket_id */)
 IPC_MESSAGE_CONTROL4(PpapiHostMsg_PPBTCPSocket_Connect,
                      int32 /* routing_id */,
                      uint32 /* socket_id */,
                      std::string /* host */,
                      uint16_t /* port */)
 IPC_MESSAGE_CONTROL3(PpapiHostMsg_PPBTCPSocket_ConnectWithNetAddress,
                      int32 /* routing_id */,
@@ skipping 715 matching lines @@
 IPC_MESSAGE_CONTROL0(PpapiPluginMsg_VideoSource_OpenReply)
 IPC_MESSAGE_CONTROL0(PpapiHostMsg_VideoSource_GetFrame)
 IPC_MESSAGE_CONTROL4(PpapiPluginMsg_VideoSource_GetFrameReply,
                      ppapi::HostResource /* resource_id */,
                      PP_ImageDataDesc /* image_data_desc */,
                      int /* fd */,
                      PP_TimeTicks /* timestamp */)
 IPC_MESSAGE_CONTROL0(PpapiHostMsg_VideoSource_Close)
 
 #endif  // !defined(OS_NACL) && !defined(NACL_WIN64)