Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1671513002: Add a GN target to build the USB gadget Python package. (Closed)

Created:
4 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a GN target to build the USB gadget Python package. This GN target matches tools/usb_gadget/usb_gadget.gyp:usb_gadget. BUG=None Committed: https://crrev.com/872fd9fcd09a8842302faa29eb4b1fac84744762 Cr-Commit-Position: refs/heads/master@{#373628}

Patch Set 1 #

Patch Set 2 : Move variables within the action definition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M device/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A tools/usb_gadget/BUILD.gn View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Reilly Grant (use Gerrit)
Thank you for volunteering.
4 years, 10 months ago (2016-02-04 21:01:49 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 10 months ago (2016-02-04 21:06:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671513002/20001
4 years, 10 months ago (2016-02-04 21:09:08 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-04 21:50:13 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 21:51:30 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/872fd9fcd09a8842302faa29eb4b1fac84744762
Cr-Commit-Position: refs/heads/master@{#373628}

Powered by Google App Engine
This is Rietveld 408576698