InstantService: provide correct SyncState to SuggestionsService

InstantService: provide correct SyncState to SuggestionsService

Also merge the two existing almost-identical implementations of GetSyncState(profile), plus do some cleanup in SuggestionsService.

BUG=514752
Committed: https://crrev.com/b75f636a043bd6fe469697712a2417dc04c12c25
Cr-Commit-Position: refs/heads/master@{#375156}

[Marc Treib, 2016-02-10 13:39:15]

Description was changed from

==========
InstantService: provide correct SyncState to SuggestionsService

Also merge the two existing almost-identical implementations of
GetSyncState(profile), plus some cleanup in SuggestionsService

BUG=
==========

to

==========
InstantService: provide correct SyncState to SuggestionsService

Also merge the two existing almost-identical implementations of
GetSyncState(profile), plus do some cleanup in SuggestionsService.

BUG=514752
==========

[Marc Treib, 2016-02-10 13:41:15]

[email protected] changed reviewers:
+ [email protected]

[Marc Treib, 2016-02-10 13:41:15]

Hi Mathieu, PTAL! (I'll add the remaining owners once you're satisfied.)

[Mathieu, 2016-02-10 15:01:35]

lgtm, nice cleanup, thanks

[Marc Treib, 2016-02-10 15:30:08]

[email protected] changed reviewers:
+ [email protected], [email protected], [email protected],
[email protected]

[Marc Treib, 2016-02-10 15:30:09]

Adding owners for all the touched files - all trivial changes.

stevenjb for suggestions_search_provider.cc
jered for instant_service.cc
mek for sessions_apitest.cc
bauerb for most_visited_sites.cc

PTAL everyone!

https://codereview.chromium.org/1686093002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/sessions/sessions_apitest.cc (left):

https://codereview.chromium.org/1686093002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/sessions/sessions_apitest.cc:168: browser_ = new
Browser(Browser::CreateParams(profile));
Moved this below the setting of defaults, otherwise we ended up calling
GetActiveDataTypes before setting its default return value.

[Jered, 2016-02-10 15:51:19]

lgtm

[Bernhard Bauer, 2016-02-10 16:05:07]

LGTM

https://codereview.chromium.org/1686093002/diff/20001/chrome/browser/search/s...
File chrome/browser/search/suggestions/suggestions_utils.cc (right):

https://codereview.chromium.org/1686093002/diff/20001/chrome/browser/search/s...
chrome/browser/search/suggestions/suggestions_utils.cc:18: return
suggestions::GetSyncState(
The suggestions:: prefix is unnecessary here, you are already in that namespace.

[Marc Treib, 2016-02-10 16:49:43]

https://codereview.chromium.org/1686093002/diff/20001/chrome/browser/search/s...
File chrome/browser/search/suggestions/suggestions_utils.cc (right):

https://codereview.chromium.org/1686093002/diff/20001/chrome/browser/search/s...
chrome/browser/search/suggestions/suggestions_utils.cc:18: return
suggestions::GetSyncState(
On 2016/02/10 16:05:07, Bernhard Bauer wrote:
> The suggestions:: prefix is unnecessary here, you are already in that
namespace.

Done.

[Marijn Kruisselbrink, 2016-02-10 19:34:48]

lgtm

[stevenjb, 2016-02-11 22:59:17]

owner lgtm

[Marc Treib, 2016-02-12 09:18:58]

The CQ bit was checked by [email protected]

[Marc Treib, 2016-02-12 09:18:58]

The patchset sent to the CQ was uploaded after l-g-t-m from [email protected],
[email protected], [email protected]
Link to the patchset: https://codereview.chromium.org/1686093002/#ps40001
(title: "remove suggestions::")

[commit-bot: I haz the power, 2016-02-12 09:19:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1686093002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1686093002/40001

[commit-bot: I haz the power, 2016-02-12 10:21:19]

Description was changed from

==========
InstantService: provide correct SyncState to SuggestionsService

Also merge the two existing almost-identical implementations of
GetSyncState(profile), plus do some cleanup in SuggestionsService.

BUG=514752
==========

to

==========
InstantService: provide correct SyncState to SuggestionsService

Also merge the two existing almost-identical implementations of
GetSyncState(profile), plus do some cleanup in SuggestionsService.

BUG=514752
==========

[commit-bot: I haz the power, 2016-02-12 10:21:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-16 22:42:33]

Description was changed from

==========
InstantService: provide correct SyncState to SuggestionsService

Also merge the two existing almost-identical implementations of
GetSyncState(profile), plus do some cleanup in SuggestionsService.

BUG=514752
==========

to

==========
InstantService: provide correct SyncState to SuggestionsService

Also merge the two existing almost-identical implementations of
GetSyncState(profile), plus do some cleanup in SuggestionsService.

BUG=514752

Committed: https://crrev.com/b75f636a043bd6fe469697712a2417dc04c12c25
Cr-Commit-Position: refs/heads/master@{#375156}
==========

[commit-bot: I haz the power, 2016-02-16 22:42:34]

Patchset 3 (id:??) landed as
https://crrev.com/b75f636a043bd6fe469697712a2417dc04c12c25
Cr-Commit-Position: refs/heads/master@{#375156}