ipc: split the process of creating unix domain socket into a separate function

ipc: split the process of creating unix domain socket into a separate function

For clarity this patch separates the process of filing sockaddr_un
(doing it first and only) in MakeUnixAddrForPath() from the process of
creating and making the unix domain socket non-blocking in another function
(only after MakeUnixAddrForPath()), called CreateUnixDomainSocket().
Because it is really weird and confusing that MakeUnixAddrForPath()
returns an non-scoped fd in case of success.

BUG=None
TEST=ipc_tests
[email protected]

Committed: https://crrev.com/8749855f3f416be125598dfd7be0ecf55ff217e6
Cr-Commit-Position: refs/heads/master@{#376666}

[tfarina, 2016-02-12 01:19:01]

Hi Adam, could you review this to me?

Thanks!

https://codereview.chromium.org/1689363002/diff/1/ipc/unix_domain_socket_util.cc
File ipc/unix_domain_socket_util.cc (right):

https://codereview.chromium.org/1689363002/diff/1/ipc/unix_domain_socket_util...
ipc/unix_domain_socket_util.cc:30: bool MakeUnixAddrForPath(const std::string&
socket_name,
Hopefully this makes it do one thing, that is setting up sockaddr_un and do it
well!

I hope you like it!

[tfarina, 2016-02-12 01:20:37]

Description was changed from

==========
ipc: split the process of creating unix domain socket into a separate function

For clarity this patch separates the process of filing sockaddr_un
(doing it first and only) in MakeUnixAddrForPath() from the process of
creating and making the unix domain socket it non-blocking in another function
(only after MakeUnixAddrForPath()), called CreateUnixDomainSocket().
Because it is really weird and confusing that MakeUnixAddrForPath()
returns an non-scoped fd in case of success.

BUG=None
TEST=ipc_tests
[email protected]
==========

to

==========
ipc: split the process of creating unix domain socket into a separate function

For clarity this patch separates the process of filing sockaddr_un
(doing it first and only) in MakeUnixAddrForPath() from the process of
creating and making the unix domain socket non-blocking in another function
(only after MakeUnixAddrForPath()), called CreateUnixDomainSocket().
Because it is really weird and confusing that MakeUnixAddrForPath()
returns an non-scoped fd in case of success.

BUG=None
TEST=ipc_tests
[email protected]
==========

[agl, 2016-02-21 15:14:30]

lgtm

[tfarina, 2016-02-21 18:39:27]

The CQ bit was checked by [email protected]

[commit-bot: I haz the power, 2016-02-21 18:39:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689363002/1

[commit-bot: I haz the power, 2016-02-21 19:52:50]

Description was changed from

==========
ipc: split the process of creating unix domain socket into a separate function

For clarity this patch separates the process of filing sockaddr_un
(doing it first and only) in MakeUnixAddrForPath() from the process of
creating and making the unix domain socket non-blocking in another function
(only after MakeUnixAddrForPath()), called CreateUnixDomainSocket().
Because it is really weird and confusing that MakeUnixAddrForPath()
returns an non-scoped fd in case of success.

BUG=None
TEST=ipc_tests
[email protected]
==========

to

==========
ipc: split the process of creating unix domain socket into a separate function

For clarity this patch separates the process of filing sockaddr_un
(doing it first and only) in MakeUnixAddrForPath() from the process of
creating and making the unix domain socket non-blocking in another function
(only after MakeUnixAddrForPath()), called CreateUnixDomainSocket().
Because it is really weird and confusing that MakeUnixAddrForPath()
returns an non-scoped fd in case of success.

BUG=None
TEST=ipc_tests
[email protected]
==========

[commit-bot: I haz the power, 2016-02-21 19:52:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-21 19:53:43]

Description was changed from

==========
ipc: split the process of creating unix domain socket into a separate function

For clarity this patch separates the process of filing sockaddr_un
(doing it first and only) in MakeUnixAddrForPath() from the process of
creating and making the unix domain socket non-blocking in another function
(only after MakeUnixAddrForPath()), called CreateUnixDomainSocket().
Because it is really weird and confusing that MakeUnixAddrForPath()
returns an non-scoped fd in case of success.

BUG=None
TEST=ipc_tests
[email protected]
==========

to

==========
ipc: split the process of creating unix domain socket into a separate function

For clarity this patch separates the process of filing sockaddr_un
(doing it first and only) in MakeUnixAddrForPath() from the process of
creating and making the unix domain socket non-blocking in another function
(only after MakeUnixAddrForPath()), called CreateUnixDomainSocket().
Because it is really weird and confusing that MakeUnixAddrForPath()
returns an non-scoped fd in case of success.

BUG=None
TEST=ipc_tests
[email protected]

Committed: https://crrev.com/8749855f3f416be125598dfd7be0ecf55ff217e6
Cr-Commit-Position: refs/heads/master@{#376666}
==========

[commit-bot: I haz the power, 2016-02-21 19:53:44]

Patchset 1 (id:??) landed as
https://crrev.com/8749855f3f416be125598dfd7be0ecf55ff217e6
Cr-Commit-Position: refs/heads/master@{#376666}